346498 - Only allow hidden and locked for restricted locations and appManaged for app-global locations

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

Patch coming up.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

This is just a simple patch for a little added protection by making it a requirement in the datasource itself for an extension to always be installed into appdir/extensions for the hidden and locked attributes to be honored.

Comment 2

[Benjamin Smedberg]

Comment on attachment 231278 [details] [diff] [review]
patch

I'm not sure I understand... will this make em:hidden and em:locked never return true, or does a null return fallback to the real database?

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 231278 [details] [diff] [review]
patch

returning null will return the value from the real rdf. I think we should probably do the same for appManaged and I'll submit another patch.

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in to trunk

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 237387 [details] [diff] [review]
patch

Drivers, this prevents an add-on from hiding or locking itself by modifying the extensions datasource and adding em:hidden / em:locked to itself. Though this isn't critical I'd like to get it in 1.8.1 so these capabilities aren't expected to work in the future unless the add-on is installed into a restricted location.

Comment 7

[Mike Schroepfer]

Comment on attachment 237387 [details] [diff] [review]
patch

a=schrep for drivers.

Comment 8

[Robert Strong (they/them - no direct email)]

Checked in to MOZILLA_1_8_BRANCH