346546 - Clean up unknownContentType.xul

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

The dialog currently looks like:

   You have chosen to open

      ## AutoHotkey104408_Install.exe

   which is a: Application
   from: http://www.autohotkey.com
   Would you like to save this file?

                                        ( Save File ) ( Cancel )

There should be an extra CR/LF between the summary and the question to the user:


   You have chosen to open

      ## AutoHotkey104408_Install.exe

   which is a: Application
   from: http://www.autohotkey.com

   Would you like to save this file?

                                        ( Save File ) ( Cancel )

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Mike, this didn't show up in your screencaps from when you added some indentation to the text in this dialog in bug 344984. Could I get you to add the extra CRLF? Should be a pretty simple fix ...

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I don't even see that text in a current trunk build - seems like the patch for bug  315536 introduced duplicate elements with the same ID (<description id="source"> and <label id="from">). This seems broken.

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #1)
> Mike, this didn't show up in your screencaps from when you added some
> indentation to the text in this dialog in bug 344984. Could I get you to add
> the extra CRLF? Should be a pretty simple fix ...
> 
If you look at the linux screenshots, it is there. That was the first thing I did when I opened bug 344984. But Windows doesn't show "Would you like to save this file" at all, most likely for the reason Gavin gave in comment #2.

Comment 4

[Michael Wu [:mwu]]

Sorry for changing this bug again, but it looks like the line not being visible was fixed by bug 315536.

Comment 5

[Michael Wu [:mwu]]

Attachment: Clean up unknownContentType.xul

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #5)
> Created an attachment (id=231505) [edit]
> Clean up unknownContentType.xul
> 
We could probably get rid of the surrounding hbox, actually..

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 231505 [details] [diff] [review]
Clean up unknownContentType.xul

r=me, sorry about the delay

Comment 8

[Michael Wu [:mwu]]

Checking in toolkit/mozapps/downloads/content/unknownContentType.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul,v  <--  unknownContentType.xul
new revision: 1.16; previous revision: 1.15
done

Comment 9

[Michael Wu [:mwu]]

Comment on attachment 231505 [details] [diff] [review]
Clean up unknownContentType.xul

Low risk, and eliminates multiple elements with the same ID.

Comment 10

[Mike Schroepfer]

Comment on attachment 231505 [details] [diff] [review]
Clean up unknownContentType.xul

a=schrep for drivers for low-risk 1.8 regression fix.

Comment 11

[Michael Wu [:mwu]]

Checking in toolkit/mozapps/downloads/content/unknownContentType.xul;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/unknownContentType.xul,v  <--  unknownContentType.xul
new revision: 1.11.2.4; previous revision: 1.11.2.3
done