The default bug view has changed. See this FAQ.

init SECItem derTemp in crmf_encode_popoprivkey

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

3.11.2
3.12
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
In bug 343682 comment 8 Wan-Teh said:

The SECItem derTemp in crmf_encode_popoprivkey
may suffer from the same problem and should also
be initialized.
Priority: -- → P5
Assignee: nobody → alexei.volkov.bugs
Priority: P5 → P3
(Assignee)

Updated

11 years ago
Assignee: alexei.volkov.bugs → kengert
(Assignee)

Comment 1

11 years ago
Created attachment 232526 [details] [diff] [review]
Patch v1

Bob, can you please review?
Attachment #232526 - Flags: review?(rrelyea)
(Assignee)

Updated

11 years ago
Blocks: 326159
(Assignee)

Updated

11 years ago
Attachment #232526 - Flags: superreview?(wtchang)

Comment 2

11 years ago
Comment on attachment 232526 [details] [diff] [review]
Patch v1

r=wtc.  When I looked at the code closely, I found that this
patch isn't necessary because when the crmf_init_encoder_callback_arg
call in crmf_encode_popoprivkey fails, derTemp.data has been set to
NULL.  This patch is a good idea because we should avoid depending on
the side effect of a function on failure.  But this means we don't
need to check this patch in on the NSS_3_11_BRANCH.
Attachment #232526 - Flags: superreview?(wtchang) → superreview+

Comment 3

11 years ago
Since the severity of this bug has been lowered to "code
cleanup to improve maintainability", it should not block
any bug.  I also suggest that we just check it in on the
NSS trunk.
Severity: normal → trivial
Target Milestone: --- → 3.12

Updated

11 years ago
No longer blocks: 326159
(Assignee)

Updated

11 years ago
Attachment #232526 - Flags: review?(rrelyea)
(Assignee)

Comment 4

11 years ago
fixed on trunk

Checking in crmfpop.c;
/cvsroot/mozilla/security/nss/lib/crmf/crmfpop.c,v  <--  crmfpop.c
new revision: 1.8; previous revision: 1.7
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.