Last Comment Bug 346551 - init SECItem derTemp in crmf_encode_popoprivkey
: init SECItem derTemp in crmf_encode_popoprivkey
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: 3.11.2
: x86 Linux
: P3 trivial (vote)
: 3.12
Assigned To: Kai Engert (:kaie)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-30 09:02 PDT by Kai Engert (:kaie)
Modified: 2006-08-07 13:03 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (710 bytes, patch)
2006-08-07 04:06 PDT, Kai Engert (:kaie)
wtc: superreview+
Details | Diff | Splinter Review

Description Kai Engert (:kaie) 2006-07-30 09:02:33 PDT
In bug 343682 comment 8 Wan-Teh said:

The SECItem derTemp in crmf_encode_popoprivkey
may suffer from the same problem and should also
be initialized.
Comment 1 Kai Engert (:kaie) 2006-08-07 04:06:45 PDT
Created attachment 232526 [details] [diff] [review]
Patch v1

Bob, can you please review?
Comment 2 Wan-Teh Chang 2006-08-07 10:39:59 PDT
Comment on attachment 232526 [details] [diff] [review]
Patch v1

r=wtc.  When I looked at the code closely, I found that this
patch isn't necessary because when the crmf_init_encoder_callback_arg
call in crmf_encode_popoprivkey fails, derTemp.data has been set to
NULL.  This patch is a good idea because we should avoid depending on
the side effect of a function on failure.  But this means we don't
need to check this patch in on the NSS_3_11_BRANCH.
Comment 3 Wan-Teh Chang 2006-08-07 10:48:59 PDT
Since the severity of this bug has been lowered to "code
cleanup to improve maintainability", it should not block
any bug.  I also suggest that we just check it in on the
NSS trunk.
Comment 4 Kai Engert (:kaie) 2006-08-07 13:03:07 PDT
fixed on trunk

Checking in crmfpop.c;
/cvsroot/mozilla/security/nss/lib/crmf/crmfpop.c,v  <--  crmfpop.c
new revision: 1.8; previous revision: 1.7
done

Note You need to log in before you can comment on or make changes to this bug.