346570 - Selecting event in unifinder doesn't select/highlight event in calendar view

Status: RESOLVED WORKSFORME

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Selecting event in unifinder doesn't select/highlight event in calendar view

Steps to Reproduce:
1. Create several events
2. Select events one by one in unifinder

Actual Results:
It is not visible in calendar view which event is selected.

Expected Results:
Selected event should be highlighted in calendar view too.

Additional Information:
Works in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006072007 Calendar/0.3a2+
Fails in Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/2006072108 Calendar/0.3a2+

Comment 1

[Joey Minta]

Attachment: add observer

selection makes me cry.  We need to add the view's observer if this is our first time showing the view.

Comment 2

[Todd Zimmerman]

Just discussing this bug on #calendar-qa and wondering if minimonth should reflect day of selected unifinder event also (just as selecting an event in calendar view does).

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231483 [details] [diff] [review]
add observer

>Index: calendar/resources/content/calendarWindow.js
>+    var view = document.getElementById(newView+"-view");
>+    if (view.displayCalendar != getCompositeCalendar()) {

Is this the only way to find out if the view has been initialized? If it is, add a comment to explain what you are doing.

Comment 4

[Joey Minta]

(In reply to comment #3)
> Is this the only way to find out if the view has been initialized? If it is,
> add a comment to explain what you are doing.
> 
Well, it was until I just checked in the initialized property of views.  However, if you review bug 321384, this patch isn't needed at all, so I'm not really inclined to update this patch

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 231483 [details] [diff] [review]
add observer

ok, let's obsolete this patch then

Comment 6

[Sebastian Schwieger]

WORKSFORME since landing of bug 321384

Comment 7

[Damian Szczepanik]

Litmus testcase 2633 created