346726 - Browse button on RTL <input type="file"> incorrectly positioned

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Niro]

Firefox does not render file-input width correctly.
As a result, some bugs appear when trying to change input width.
In addition, there is another bug which is not related to the width issue, and appear only when direction is RTL.
For details, see the upcoming testcase.

Comment 1

[Niro]

Attachment: testcase

Comment 2

[Niro]

Attachment: Screenshot

screenshot from: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060731 Minefield/3.0a1

Comment 3

[Magnus Melin [:mkmelin]]

*** This bug has been marked as a duplicate of 52500 ***

Comment 4

[Niro]

What about the RTL bug? (third div)
The input doesn't has style properties and it's buggy.
Maybe it's a separate bug?

Comment 5

[Simon Montagu :smontagu]

Reopening for the RTL issue

Comment 6

[Simon Montagu :smontagu]

It would be interesting to know when this regressed. The ultimate cause is code at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/forms/nsFileControlFrame.cpp&rev=3.194&mark=403-414#402
I assume that that workaround was effective at the time, but apparently the bug that it is working around has since been fixed and the workaround is now causing the incorrect positioning.

Comment 7

[Simon Montagu :smontagu]

Attachment: Patch

This fixes the testcase here without regressing bug 118509.

Comment 8

[Niro]

Someone on the IRC has the same problem on Mac.
Changing to ALL/ALL.

Comment 9

[Uri Bernstein]

Comment on attachment 231588 [details] [diff] [review]
Patch

r=me.

FWIW, The regression was somewhere between Mozilla 1.2 and Mozilla 1.3. Finding nightlies from that era is difficult.

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 231588 [details] [diff] [review]
Patch

nice!

Comment 11

[Simon Montagu :smontagu]

Checked in.

Comment 12

[Simon Montagu :smontagu]

Comment on attachment 231588 [details] [diff] [review]
Patch

This is low-risk since it is only removing unnecessary code, and corrects an ugly bug in forms.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 231588 [details] [diff] [review]
Patch

a=dbaron on behalf of drivers.  Please land on MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword once you have done so.

Comment 14

[Simon Montagu :smontagu]

The testcase still doesn't display perfectly on the branch. Uri says that this is probably because of bug 318116.

Comment 15

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).