Closed Bug 346728 Opened 18 years ago Closed 18 years ago

Image blocking notification is ambiguous, should show hostname

Categories

(Firefox :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: polidobj, Assigned: jminta)

References

Details

(Keywords: verified1.8.1)

After bug 345349 a notification bar appears when an image is selected to be blocked.  That notification says:
Firefox will now block images from this site

Which site?

I would say that typically when an image is blocked it is blocked from a third party server.  In that case images are not blocked from this site but from site X.

So the message should indicate which site is blocked.

e.g. Firefox will now block images from Site_X.com.
Flags: blocking-firefox2?
Summary: Image blocking notification is ambiguous → Image blocking notification is ambiguous, should show hostname
Not a blocker, but if the site name is available to the notification message, it certainly wouldn't hurt to throw a (%S) into that message.
Assignee: nobody → jwalden+bmo
Flags: blocking-firefox2? → blocking-firefox2-
Whiteboard: [would take patch]
(In reply to comment #1)
> Not a blocker, but if the site name is available to the notification message,
> it certainly wouldn't hurt to throw a (%S) into that message.
> 
This is included in the patch in bug 346486.
Assignee: jwalden+bmo → nobody
Depends on: 346486
Whiteboard: [would take patch]
Assignee: nobody → jminta
Fixed by bug 346486.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Verified that the hostname is shown when the image blocking notification is shown on trunk and 20060821 Firefox/2.0b2.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.