346744 - Make nsIContent::AppendChildTo into an inline forward to nsIContent::InsertChildAt

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

bz and I have talked about this a bit so I figured I should just go ahead and do it.

The one issue with this is that having AppendChildTo used to allow us to work properly with lazy templates in XUL. However that is currently broken anyway. I think the way to solve that is to make the XUL prototype wrapping code call some special function on nsXULElement so this patch should not make that harder.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: Patch to fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 231492 [details] [diff] [review]
Patch to fix

>Index: content/xtf/src/nsXTFElementWrapper.cpp
>-  if (mNotificationMask & (nsIXTFElement::NOTIFY_WILL_APPEND_CHILD |
>-                           nsIXTFElement::NOTIFY_CHILD_APPENDED))

So we can nuke those two enum values from the IDL, right?

>-    GetXTFElement()->WillAppendChild(domKid);
...
>-    GetXTFElement()->ChildAppended(domKid);

And those methods?

File a followup bug on XTF on that?

r+sr=bzbarsky

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Checked in.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I filed bug 346754 on the xtf issue