346764 - Change "Software Installation" to "Add-ons Installation"

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Behnam Esfahbod [:zwnj]]

browser/preferences/preferences.properties:
* installpermissionstitle = "Allowed Sites - Software Installation"

Other places firefox talks about installing "Addons" not "Software".  It's confusing.

Comment 1

[Behnam Esfahbod [:zwnj]]

And what's this "Downloading Software"?

* downloadpermissionstitle = "Allowed Sites - Downloading Software"

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: s/software/add-ons in a couple of places, revved entity names

This patch also gets rid of downloadpermissionstext and downloadpermissionstitle which are no longer used.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 231545 [details] [diff] [review]
s/software/add-ons in a couple of places, revved entity names

r=me, though I'd like Axel to confirm that removing the unused entities won't cause more trouble than it's worth at this point. Since localizers will need to open up this file and look at this bug anyways, I guess it doesn't really hurt?

Comment 4

[Axel Hecht [:Pike]]

Removing those is fine for me, given Gavin's rationale.

Comment 5

[Reed Loden [:reed]]

Comment on attachment 231545 [details] [diff] [review]
s/software/add-ons in a couple of places, revved entity names

Requesting a1.8.1. Just string and entity name changes.

Comment 6

[Matthew (lilmatt) Willis]

patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED

Comment 7

[Reed Loden [:reed]]

addonspermissionstitle should have been "Allowed Sites - Add-ons Installation" :/

Comment 8

[Reed Loden [:reed]]

I'll get a patch for this in a bit. No need for blocking.

Comment 9

[Reed Loden [:reed]]

Attachment: Use "Add-ons Installation" - v1

Add the word "Installation" after "Add-ons".

Comment 10

[Reed Loden [:reed]]

Attachment: congruency is bad - v2

Well, I was trying to retain congruency, but it would probably only cause the l10n people more work. Just change the one instead.

Comment 11

[Robert Strong (they/them - no direct email)]

Comment on attachment 232094 [details] [diff] [review]
congruency is bad - v2

Thanks for the patch

Comment 12

[Reed Loden [:reed]]

Comment on attachment 232094 [details] [diff] [review]
congruency is bad - v2

Requesting a1.8.1. Just adds the word "Installation" to the exceptions dialog title for add-ons installation.

Comment 13

[Robert Strong (they/them - no direct email)]

Comment on attachment 232094 [details] [diff] [review]
congruency is bad - v2

reed, I am taking back the + because you missed a change
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/security.js#85

Comment 14

[Reed Loden [:reed]]

Attachment: oops, forgot a file - v3

Try this one more time.

Comment 15

[Robert Strong (they/them - no direct email)]

Comment on attachment 232098 [details] [diff] [review]
oops, forgot a file - v3

>Index: browser/locales/en-US/chrome/browser/preferences/preferences.properties
>===================================================================
>RCS file: /cvsroot/mozilla/browser/locales/en-US/chrome/browser/preferences/preferences.properties,v
>retrieving revision 1.8
>diff -u -p -r1.8 preferences.properties
>--- browser/locales/en-US/chrome/browser/preferences/preferences.properties	2 Aug 2006 05:14:43 -0000	1.8
>+++ browser/locales/en-US/chrome/browser/preferences/preferences.properties	4 Aug 2006 09:32:35 -0000
>@@ -39,7 +39,7 @@ labelDefaultFont=Default (%S)
> cookiepermissionstext=You can specify which web sites are always or never allowed to use cookies.  Type the exact address of the site you want to manage and then click Block, Allow for Session, or Allow.
> cookiepermissionstitle=Exceptions - Cookies
> addonspermissionstext=You can specify which web sites are allowed to install add-ons. Type the exact address of the site you want to allow and then click Allow.
>-addonspermissionstitle=Allowed Sites - Add-ons
>+addons_permissions_title=Allowed Sites - Add-ons Installation
> popuppermissionstext=You can specify which web sites are allowed to open popup windows. Type the exact address of the site you want to allow and then click Allow.
> popuppermissionstitle=Allowed Sites - Popups
> imagepermissionstext=You can specify which web sites are allowed to load images. Type the exact address of the site you want to manage and then click Block or Allow.
>Index: browser/base/content/browser.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/base/content/browser.js,v
>retrieving revision 1.674
>diff -u -p -r1.674 browser.js
>--- browser/base/content/browser.js	3 Aug 2006 19:19:02 -0000	1.674
>+++ browser/base/content/browser.js	4 Aug 2006 09:32:40 -0000
>@@ -727,7 +727,7 @@ function xpinstallEditPermissions(aDocSh
>                    allowVisible   : true,
>                    prefilledHost  : webNav.currentURI.host,
>                    permissionType : "install",
>-                   windowTitle    : bundlePreferences.getString("addonspermissionstitle"),
>+                   windowTitle    : bundlePreferences.getString("addons_permissions_title"),
>                    introText      : bundlePreferences.getString("addonspermissionstext") };
>     wm = Components.classes["@mozilla.org/appshell/window-mediator;1"]
>                    .getService(Components.interfaces.nsIWindowMediator);
>Index: browser/components/preferences/security.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/preferences/security.js,v
>retrieving revision 1.4
>diff -u -p -r1.4 security.js
>--- browser/components/preferences/security.js	2 Aug 2006 05:14:43 -0000	1.4
>+++ browser/components/preferences/security.js	4 Aug 2006 09:32:40 -0000
>@@ -82,7 +82,7 @@ var gSecurityPane = {
> 
>     var params = this._addonParams;
>     if (!params.windowTitle || !params.introText) {
>-      params.windowTitle = bundlePrefs.getString("addonspermissionstitle");
>+      params.windowTitle = bundlePrefs.getString("addons_permissions_title");
>       params.introText = bundlePrefs.getString("addonspermissionstext");
>     }
>

Comment 16

[Reed Loden [:reed]]

Comment on attachment 232098 [details] [diff] [review]
oops, forgot a file - v3

Requesting a1.8.1. Just adds the word "Installation" to the exceptions dialog title for add-ons installation.

Comment 17

[Mike Connor [:mconnor]]

Comment on attachment 232098 [details] [diff] [review]
oops, forgot a file - v3

a=mconnor on behalf of drivers for checkin to 1.8 branch

Comment 18

[:Gavin Sharp [email: [e-mail]]]

browser/base/content/browser.js 1.479.2.181
browser/locales/en-US/chrome/browser/preferences/preferences.properties 1.4.8.5
browser/components/preferences/security.js 	1.3.2.3
browser/components/preferences/security.js 	1.5
browser/base/content/browser.js 	1.676
browser/locales/en-US/chrome/browser/preferences/preferences.properties 1.9