Closed
Bug 346795
Opened 17 years ago
Closed 17 years ago
wording of text in automatic updates dialog after new update has been downloaded
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8.1beta2
People
(Reporter: tuukka.tolvanen, Assigned: beltzner)
References
Details
(Keywords: fixed1.8.1, late-l10n)
Attachments
(5 files, 3 obsolete files)
7.66 KB,
patch
|
Details | Diff | Splinter Review | |
7.43 KB,
patch
|
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
5.74 KB,
patch
|
Details | Diff | Splinter Review | |
1.22 KB,
patch
|
Details | Diff | Splinter Review | |
3.11 KB,
patch
|
myk
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
"The update you just downloaded will be installed the next time you start %S." is rather annoyingly revisionist, I didn't download an update and pop up dialogs interrupting my work, so there's a bit of an adding insult to injury thing here ;) http://lxr.mozilla.org/mozilla/search?string=update%20you%20just%20downloaded tbird trunk 20060729 (update component only in fx product...) bug 334767 probably solves this pretty much str: receive automatic update, get update dialog when download complete, press Later actual: app tells me I downloaded stuff expected: app tells me it downloaded stuff. or just s/you just downloaded//
Comment 1•17 years ago
|
||
I don't understand why this is marked as depending on bug 334767. Whether the dialog shows up at all and what the wording in the dialog is are seperate issues.
Summary: "The update you just downloaded ..." is inaccurate → wording of text in automatic updates dialog after new update has been downloaded
Assignee | ||
Comment 2•17 years ago
|
||
Tuukka, with bug 334767 comment 29, would you now consider this a dupe?
Reporter | ||
Comment 3•17 years ago
|
||
they're fine, assuming one of those in updates.dtd replaces this one in updates.properties
Assignee | ||
Comment 4•17 years ago
|
||
This is a split off from bug 334767 comment 29 which softens the language used by the installer to be a little less imperative. It also resolves bug 305383 by explicitly mentioning that session restore will activate if a user clicks "Restart".
Attachment #233730 -
Flags: review?(mconnor)
Assignee | ||
Updated•17 years ago
|
Assignee | ||
Comment 5•17 years ago
|
||
crap, missed a line removal ...
Attachment #233730 -
Attachment is obsolete: true
Attachment #233731 -
Flags: review?(mconnor)
Attachment #233730 -
Flags: review?(mconnor)
Assignee | ||
Comment 6•17 years ago
|
||
*** Bug 340156 has been marked as a duplicate of this bug. ***
Comment 7•17 years ago
|
||
Is this string "If you restart now, &brandShortName; will restore your tabs and windows" appropriate to the other toolkit apps ? AFAIK they don't restore the session when you restart them. Can we override the toolkit string with a Firefox specific one ? Or split it out into a seperate entity and use JS logic/preprocessing to determine whether to display it or not ?
Assignee | ||
Comment 8•17 years ago
|
||
This version doesn't mention session restore, attaching in case we come up against the l10n deadline and don't have an override solution in place. I'd prefer the strings from v2, but these are at least an improvement over what we have now.
Attachment #233776 -
Flags: review?(mconnor)
Updated•17 years ago
|
Attachment #233776 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•17 years ago
|
Whiteboard: [checkin needed]
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → beltzner
Assignee | ||
Comment 9•17 years ago
|
||
Comment on attachment 233776 [details] [diff] [review] softens the language in the updater v3 (no mention of session restore) Drivers: low risk here, just a string change.
Attachment #233776 -
Flags: approval1.8.1?
Comment 10•17 years ago
|
||
Patch v3 landed on trunk. Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.dtd; /cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd,v <-- updates.dtd new revision: 1.20; previous revision: 1.19 done Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.properties; /cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.properties,v <-- updates.properties new revision: 1.31; previous revision: 1.30 done Checking in toolkit/mozapps/update/content/updates.js; /cvsroot/mozilla/toolkit/mozapps/update/content/updates.js,v <-- updates.js new revision: 1.61; previous revision: 1.60 done Checking in toolkit/mozapps/update/content/updates.xul; /cvsroot/mozilla/toolkit/mozapps/update/content/updates.xul,v <-- updates.xul new revision: 1.26; previous revision: 1.25 done
Whiteboard: [checkin needed]
Comment 11•17 years ago
|
||
Comment on attachment 233776 [details] [diff] [review] softens the language in the updater v3 (no mention of session restore) +<!ENTITY finishedBackground.detail1 "Click Restart &brandShortName; Now to install the update now. You didn't close the entity declaration with ">.
Assignee | ||
Comment 12•17 years ago
|
||
better patch for branch and trunk checkin to fix missing entity ending - oops
Attachment #233776 -
Attachment is obsolete: true
Attachment #233776 -
Flags: approval1.8.1?
Assignee | ||
Updated•17 years ago
|
Attachment #233999 -
Flags: approval1.8.1?
Assignee | ||
Updated•17 years ago
|
Whiteboard: [checkin needed]
Comment 13•17 years ago
|
||
Trunk typo patch checked in. mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd 1.21
Status: NEW → RESOLVED
Closed: 17 years ago
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: Trunk → 2.0 Branch
Updated•17 years ago
|
Attachment #233731 -
Flags: review?(mconnor)
Assignee | ||
Comment 14•17 years ago
|
||
Myk noticed a missing "it" after a comma; once approved, he's going to check that change in on trunk and check the branch patch in with the change as well.
Updated•17 years ago
|
Attachment #233999 -
Flags: approval1.8.1? → approval1.8.1+
Comment 15•17 years ago
|
||
Patch v4 with the added "it" has been checked into the branch, and I also checked in a patch to the trunk which adds the "it" there too. I'll attach both patches for posterity.
Keywords: fixed1.8.1
Comment 16•17 years ago
|
||
This is v4 with the added "it". It is the patch that was checked into the branch.
Comment 17•17 years ago
|
||
Comment 18•17 years ago
|
||
finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 19•17 years ago
|
||
(In reply to comment #18) > finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird. Frack. Patch coming up.
Assignee | ||
Comment 20•17 years ago
|
||
changing one word and revving entities
Attachment #234079 -
Flags: review?(myk)
Assignee | ||
Comment 21•17 years ago
|
||
this one
Attachment #234079 -
Attachment is obsolete: true
Attachment #234080 -
Flags: review?(myk)
Attachment #234079 -
Flags: review?(myk)
Comment 22•17 years ago
|
||
Comment on attachment 234080 [details] [diff] [review] follow up patch, s/browsing/working/, revved entities Looks good. r=myk
Attachment #234080 -
Flags: review?(myk) → review+
Assignee | ||
Comment 23•17 years ago
|
||
Comment on attachment 234080 [details] [diff] [review] follow up patch, s/browsing/working/, revved entities a=beltzner on behalf of drivers, please land on the MOZILLA_1_8_BRANCH and mark fixed1.8.1 (uh, already is!)
Attachment #234080 -
Flags: approval1.8.1+
Comment 24•17 years ago
|
||
Followup patch checked in to the 1.8 branch. Leaving bug open pending trunk checkin (which will happen as soon as the trunk reopens).
Comment 25•17 years ago
|
||
Followup patch checked into the trunk.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•