346795 - wording of text in automatic updates dialog after new update has been downloaded

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Tuukka Tolvanen (sp3000)]

"The update you just downloaded will be installed the next time you start %S." is rather annoyingly revisionist, I didn't download an update and pop up dialogs interrupting my work, so there's a bit of an adding insult to injury thing here ;)

http://lxr.mozilla.org/mozilla/search?string=update%20you%20just%20downloaded

tbird trunk 20060729 (update component only in fx product...)

bug 334767 probably solves this pretty much

str: receive automatic update, get update dialog when download complete, press Later
actual: app tells me I downloaded stuff
expected: app tells me it downloaded stuff. or just s/you just downloaded//

Comment 1

[Jeremy Baron]

I don't understand why this is marked as depending on bug 334767.  Whether the dialog shows up at all and what the wording in the dialog is are seperate issues.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Tuukka, with bug 334767 comment 29, would you now consider this a dupe?

Comment 3

[Tuukka Tolvanen (sp3000)]

they're fine, assuming one of those in updates.dtd replaces this one in updates.properties

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: softens the language in the updater

This is a split off from bug 334767 comment 29 which softens the language used by the installer to be a little less imperative. It also resolves bug 305383 by explicitly mentioning that session restore will activate if a user clicks "Restart".

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: softens the language in the updater v2

crap, missed a line removal ...

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 340156 has been marked as a duplicate of this bug. ***

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Is this string
  "If you restart now, &brandShortName; will restore your tabs and windows" appropriate to the other toolkit apps ? AFAIK they don't restore the session when you restart them. 

Can we override the toolkit string with a Firefox specific one ? Or split it out into a seperate entity and use JS logic/preprocessing to determine whether to display it or not ?

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: softens the language in the updater v3 (no mention of session restore)

This version doesn't mention session restore, attaching in case we come up against the l10n deadline and don't have an override solution in place. I'd prefer the strings from v2, but these are at least an improvement over what we have now.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233776 [details] [diff] [review]
softens the language in the updater v3 (no mention of session restore)

Drivers: low risk here, just a string change.

Comment 10

[Joey Minta]

Patch v3 landed on trunk.
Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd,v  <--  updates.dtd
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.properties,v  <--  updates.properties
new revision: 1.31; previous revision: 1.30
done
Checking in toolkit/mozapps/update/content/updates.js;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.js,v  <--  updates.js
new revision: 1.61; previous revision: 1.60
done
Checking in toolkit/mozapps/update/content/updates.xul;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.xul,v  <--  updates.xul
new revision: 1.26; previous revision: 1.25
done

Comment 11

[Marek Stępień [:marcoos, inactive]]

Comment on attachment 233776 [details] [diff] [review]
softens the language in the updater v3 (no mention of session restore)

+<!ENTITY  finishedBackground.detail1      "Click Restart &brandShortName; Now to install the update now. 

You didn't close the entity declaration with ">.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: softens the language in the updater v4 (with closed entity)

better patch for branch and trunk checkin to fix missing entity ending - oops

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Trunk typo patch checked in.
mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd 	1.21

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Myk noticed a missing "it" after a comma; once approved, he's going to check that change in on trunk and check the branch patch in with the change as well.

Comment 15

[Myk Melez [:myk] [@mykmelez]]

Patch v4 with the added "it" has been checked into the branch, and I also checked in a patch to the trunk which adds the "it" there too.  I'll attach both patches for posterity.

Comment 16

[Myk Melez [:myk] [@mykmelez]]

Attachment: v4 with added "it"

This is v4 with the added "it".  It is the patch that was checked into the branch.

Comment 17

[Myk Melez [:myk] [@mykmelez]]

Attachment: followup patch adding "it" to the trunk

Comment 18

[Alex Ihrig [:Thunderbird_Mail_DE]]

finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird.

Comment 19

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #18)
> finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird.

Frack.

Patch coming up.

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: follow up patch, s/browsing/working/, revved entities

changing one word and revving entities

Comment 21

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: follow up patch, s/browsing/working/, revved entities

this one

Comment 22

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 234080 [details] [diff] [review]
follow up patch, s/browsing/working/, revved entities

Looks good. r=myk

Comment 23

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 234080 [details] [diff] [review]
follow up patch, s/browsing/working/, revved entities

a=beltzner on behalf of drivers, please land on the MOZILLA_1_8_BRANCH and mark fixed1.8.1 (uh, already is!)

Comment 24

[Myk Melez [:myk] [@mykmelez]]

Followup patch checked in to the 1.8 branch.  Leaving bug open pending trunk checkin (which will happen as soon as the trunk reopens).

Comment 25

[Myk Melez [:myk] [@mykmelez]]

Followup patch checked into the trunk.