Closed Bug 346795 Opened 18 years ago Closed 18 years ago

wording of text in automatic updates dialog after new update has been downloaded

Categories

(Toolkit :: Application Update, defect)

1.8 Branch
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.8.1beta2

People

(Reporter: tuukka.tolvanen, Assigned: beltzner)

References

Details

(Keywords: fixed1.8.1, late-l10n)

Attachments

(5 files, 3 obsolete files)

"The update you just downloaded will be installed the next time you start %S." is rather annoyingly revisionist, I didn't download an update and pop up dialogs interrupting my work, so there's a bit of an adding insult to injury thing here ;)

http://lxr.mozilla.org/mozilla/search?string=update%20you%20just%20downloaded

tbird trunk 20060729 (update component only in fx product...)

bug 334767 probably solves this pretty much

str: receive automatic update, get update dialog when download complete, press Later
actual: app tells me I downloaded stuff
expected: app tells me it downloaded stuff. or just s/you just downloaded//
I don't understand why this is marked as depending on bug 334767.  Whether the dialog shows up at all and what the wording in the dialog is are seperate issues.
Summary: "The update you just downloaded ..." is inaccurate → wording of text in automatic updates dialog after new update has been downloaded
Tuukka, with bug 334767 comment 29, would you now consider this a dupe?
they're fine, assuming one of those in updates.dtd replaces this one in updates.properties
This is a split off from bug 334767 comment 29 which softens the language used by the installer to be a little less imperative. It also resolves bug 305383 by explicitly mentioning that session restore will activate if a user clicks "Restart".
Attachment #233730 - Flags: review?(mconnor)
Keywords: late-l10n
OS: Linux → All
Target Milestone: --- → Firefox 2 beta2
crap, missed a line removal ...
Attachment #233730 - Attachment is obsolete: true
Attachment #233731 - Flags: review?(mconnor)
Attachment #233730 - Flags: review?(mconnor)
*** Bug 340156 has been marked as a duplicate of this bug. ***
Is this string
  "If you restart now, &brandShortName; will restore your tabs and windows" appropriate to the other toolkit apps ? AFAIK they don't restore the session when you restart them. 

Can we override the toolkit string with a Firefox specific one ? Or split it out into a seperate entity and use JS logic/preprocessing to determine whether to display it or not ?
This version doesn't mention session restore, attaching in case we come up against the l10n deadline and don't have an override solution in place. I'd prefer the strings from v2, but these are at least an improvement over what we have now.
Attachment #233776 - Flags: review?(mconnor)
Attachment #233776 - Flags: review?(mconnor) → review+
Whiteboard: [checkin needed]
Assignee: nobody → beltzner
Comment on attachment 233776 [details] [diff] [review]
softens the language in the updater v3 (no mention of session restore)

Drivers: low risk here, just a string change.
Attachment #233776 - Flags: approval1.8.1?
Patch v3 landed on trunk.
Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd,v  <--  updates.dtd
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/locales/en-US/chrome/mozapps/update/updates.properties;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.properties,v  <--  updates.properties
new revision: 1.31; previous revision: 1.30
done
Checking in toolkit/mozapps/update/content/updates.js;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.js,v  <--  updates.js
new revision: 1.61; previous revision: 1.60
done
Checking in toolkit/mozapps/update/content/updates.xul;
/cvsroot/mozilla/toolkit/mozapps/update/content/updates.xul,v  <--  updates.xul
new revision: 1.26; previous revision: 1.25
done
Whiteboard: [checkin needed]
Comment on attachment 233776 [details] [diff] [review]
softens the language in the updater v3 (no mention of session restore)

+<!ENTITY  finishedBackground.detail1      "Click Restart &brandShortName; Now to install the update now. 

You didn't close the entity declaration with ">.
better patch for branch and trunk checkin to fix missing entity ending - oops
Attachment #233776 - Attachment is obsolete: true
Attachment #233776 - Flags: approval1.8.1?
Attachment #233999 - Flags: approval1.8.1?
Whiteboard: [checkin needed]
Trunk typo patch checked in.
mozilla/toolkit/locales/en-US/chrome/mozapps/update/updates.dtd 	1.21
Status: NEW → RESOLVED
Closed: 18 years ago
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Version: Trunk → 2.0 Branch
Attachment #233731 - Flags: review?(mconnor)
Myk noticed a missing "it" after a comma; once approved, he's going to check that change in on trunk and check the branch patch in with the change as well.
Attachment #233999 - Flags: approval1.8.1? → approval1.8.1+
Patch v4 with the added "it" has been checked into the branch, and I also checked in a patch to the trunk which adds the "it" there too.  I'll attach both patches for posterity.
Keywords: fixed1.8.1
This is v4 with the added "it".  It is the patch that was checked into the branch.
finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to comment #18)
> finishedBackground.detail2 "...browsing...." isn't correct for Thunderbird.

Frack.

Patch coming up.
changing one word and revving entities
Attachment #234079 - Flags: review?(myk)
this one
Attachment #234079 - Attachment is obsolete: true
Attachment #234080 - Flags: review?(myk)
Attachment #234079 - Flags: review?(myk)
No longer depends on: 334767
Comment on attachment 234080 [details] [diff] [review]
follow up patch, s/browsing/working/, revved entities

Looks good. r=myk
Attachment #234080 - Flags: review?(myk) → review+
Comment on attachment 234080 [details] [diff] [review]
follow up patch, s/browsing/working/, revved entities

a=beltzner on behalf of drivers, please land on the MOZILLA_1_8_BRANCH and mark fixed1.8.1 (uh, already is!)
Attachment #234080 - Flags: approval1.8.1+
Followup patch checked in to the 1.8 branch.  Leaving bug open pending trunk checkin (which will happen as soon as the trunk reopens).
Followup patch checked into the trunk.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: