346863 - Approval: adjust yahoo suggest URL

Status: RESOLVED FIXED

(Mozilla Localizations :: ko / Korean, defect)

Description

[Axel Hecht [:Pike]]

We got a request to adjust the suggestions URL to

<Url type="application/x-suggestions+json" method="GET"
     template="http://kr.ff.search.yahoo.com/?output=fxjson&amp;command={searchTerms}" />

The other plugins are in bad need for an update, too. I don't think that you need the google-kr plugin at all, just reference the 'google' one in list.txt, that will be picked up from en-US.

Comment 1

[Channy Yun [:channy]]

Is your url from yahoo suggestion url? So Is it replace not <Url> but <SuggestionUrl> entity? I know Url is web page url to search keyword.

I changed the search url from google.com to google.co.kr in google.xml. So I changed it to google-kr.xml. Can I need to google-kr to google if it does?

Comment 2

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #1)
> I changed the search url from google.com to google.co.kr in google.xml. So I
> changed it to google-kr.xml. Can I need to google-kr to google if it does?

No.

Remove google-kr.xml, then change "google-kr" to "google" in list.txt

The search plugin will be picked up from en-US, and the language detection will be done server-side.

Comment 3

[Axel Hecht [:Pike]]

(In reply to comment #1)
> Is your url from yahoo suggestion url? So Is it replace not <Url> but
> <SuggestionUrl> entity? I know Url is web page url to search keyword.

SuggestionUrl is not used anymore, it was an intermediate design step, and a bad one apparently. Regular search queries only differ in the type attribute from suggest queries. Your yahoo plugin should have two Url elements, one for regular search, one for suggest, the second should be as depicted in the initial comment.

Comment 4

[Channy Yun [:channy]]

Attachment: yahoo-kr.xml patch

Comment 5

[Channy Yun [:channy]]

Attachment: add google.xml and del google-kr.xml

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 232884 [details]
add google.xml and del google-kr.xml

This one should be a patch to list.txt, and there is no need to actually add google.xml, as that is going to be picked up from the en-US source directory.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 232883 [details] [diff] [review]
yahoo-kr.xml patch

This fix looks right.

For future reference, we're much more familiar with cvs diff -u, which makes reviewing easier.

Comment 8

[Channy Yun [:channy]]

I committed yahoo-kr.xml.

Comment 9

[Channy Yun [:channy]]

Attachment: list.txt patch

I changed google-kr to google in list.txt Please check out!

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 233035 [details] [diff] [review]
list.txt patch

To understand this patch, you're reverting back to the order and list of the 1.8.0-branch version, not adding eBay and answers to list.txt in comparison to Firefox 1.5.0.x?

Comment 11

[Channy Yun [:channy]]

I will follow up issues of search plugin in Bug 348101.