347009 - Critical string changes for FF 1.5 - Connected Files feature, Bookmarks, Help call

Status: VERIFIED FIXED

Description

[Ton [:Tonnes]]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.0.5) Gecko/20060719 Firefox/1.5.0.5
Build Identifier: 

This should fix some basic issues inside the nl locale for FF/TB 1.5.

- Compatibility with Connected Files feature is broken as currently no underscores are used where they (unfortunately) should for Dutch. See bug 232075.
- Shared access key for File menu and New bookmark button in Bookmarks manager, making the first one unusable as a new bookmark is always opened.
- Help section for Clear private data is not accessible very well, as a result of an erroneous sanitize-to-cpd change.
- A typo and a few bad translations for tooltips that reside in one of the CF feature related files.

Reproducible: Always

Comment 1

[Ton [:Tonnes]]

Created attachment 231753 [details] [diff] [review]
The fix

Comment 2

[Ton [:Tonnes]]

Created attachment 231761 [details] [diff] [review]
Tooltip for search bar

A minor tooltip+key issue I wanted to include but which could break the rest, as this file appears to have a CR/LF problem.

Comment 3

[Daniel Veditz [:dveditz]]

Restoring lost blocking flag

Comment 4

[Daniel Veditz [:dveditz]]

Axel: are we taking localization changes in 1.5.0.8? I imagine so since we want to get the "major update available" patches in too, and in that case this is probably fine for 1.8.0.8 as well.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 231753 [details] [diff] [review]
The fix

Axel, we'll take these in 1.8.0.8 on your approval.

Comment 6

[Daniel Veditz [:dveditz]]

Won't hold the release for it, but we'll approve the patches if Axel does.

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 231761 [details] [diff] [review]
Tooltip for search bar

[nl] accesskey fixes approved for 1.8.0.9.

Please use the fixed1.8.0.9 and verified1.8.0.9 keywords to track landing and testing.

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 231753 [details] [diff] [review]
The fix

[nl] fix for connected files approved for 1.8.0.9.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 231753 [details] [diff] [review]
The fix

[nl] fix for connected files approved for 1.8.0.9.
(setting the flag, too)

Comment 10

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 231753 [details] [diff] [review]
The fix

patch applied on the 1_8_0_branch

Comment 11

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 231761 [details] [diff] [review]
Tooltip for search bar

patch applied to the mozilla_1_8_0_branch

Comment 12

[Tim Maks van den Broek [:mad_maks]]

both fixes are applied.

Comment 13

[Tim Maks van den Broek [:mad_maks]]

verified: 
Mozilla/5.0 (X11; U; Linux i686; nl; rv:1.8.0.9pre) Gecko/20061126 Firefox/1.5.0.9pre

Comment 14

[Axel Hecht [:Pike]]

Adding verified keywords according to Tim's comments.