34701 - UMR in nsXMLMIMEDataSource.cpp

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Simon Fraser [no longer active]]

There is some badness in nsXMLMIMEDataSource::GetFromTypeCreator that means that 
the type/creator info is not properly put into the key string. Here's the patch:

Index: nsXMLMIMEDataSource.cpp
===================================================================
RCS file: /cvsroot/mozilla/netwerk/mime/src/nsXMLMIMEDataSource.cpp,v
retrieving revision 1.2
diff -w -c -1 -r1.2 nsXMLMIMEDataSource.cpp
*** nsXMLMIMEDataSource.cpp	2000/04/05 06:18:10	1.2
--- nsXMLMIMEDataSource.cpp	2000/04/05 22:08:15
***************
*** 552,557 ****
  		    
!     char buf[16];
      buf[0] = aType;
!     buf[4] = aCreator;
!     nsAutoString keyString( buf,8 );
      keyString+=aExt;
--- 552,557 ----
  		    
!     PRUint32 buf[2];
      buf[0] = aType;
!     buf[1] = aCreator;
!     nsAutoString keyString((char *)buf, 8);
      keyString+=aExt;

Comment 1

[Simon Fraser [no longer active]]

PDT+, since this might cause unpredictable behaviour.

Comment 2

[Simon Fraser [no longer active]]

This is a no-brainer fix (and the fix is in-hand). I argue for M15.

Comment 3

[davidm]

fix checked in

Comment 4

[Tom Everingham]

development issue, marking verified