Closed
Bug 347057
Opened 19 years ago
Closed 19 years ago
Report errors which lead to a fallback to the internal viewer in the console
Categories
(Toolkit :: View Source, defect)
Toolkit
View Source
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: zeniko, Assigned: zeniko)
Details
Attachments
(1 file)
|
2.34 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•19 years ago
|
||
This patch at least makes it easier to see what went wrong when we get the internal viewer as a fall back.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #231808 -
Flags: review? → review?(gavin.sharp)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 231808 [details] [diff] [review]
use reportError
r=me, but please get a browser peer to approve this too.
Attachment #231808 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #231808 -
Flags: superreview?(mconnor)
|
|
Assignee | |
Comment 3•19 years ago
|
||
Comment on attachment 231808 [details] [diff] [review]
use reportError
Gavin: Would you mind reconsidering your r+ as one of a browser peer and checking this patch in? Thanks.
Attachment #231808 -
Flags: superreview?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Whiteboard: [checkin needed]
|
||
Comment 5•19 years ago
|
||
mozilla/toolkit/components/viewsource/content/viewSourceUtils.js 1.5
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
|
|
||
Comment 6•19 years ago
|
||
doesn't need a test, since the patch is just adding debug output in case of failure.
Flags: in-testsuite-
|
||
Updated•17 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•