[SessionStore] Correctly JSON-ify the API

RESOLVED INVALID

Status

()

Firefox
Session Restore
RESOLVED INVALID
11 years ago
11 years ago

People

(Reporter: Simon Bünzli, Unassigned)

Tracking

unspecified
Firefox 2 beta2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

11 years ago
Until bug 340987 gets fixed (which would make this dead-simple), we should probably fall back on using Douglas Crockford's toJSONString/parseJSON methods from http://www.json.org/json.js .
Requesting blocking, as bug 344640 can't move forward until this is addressed.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta2
(Reporter)

Comment 2

11 years ago
Note that there is already a fully JSON-compliant patch attached to bug 344640 so this bug might get unnecessary soon.
(In reply to comment #2)
> Note that there is already a fully JSON-compliant patch attached to bug 344640
> so this bug might get unnecessary soon.
> 

Shaver is saying that evalInSandbox is not sufficient, and that we should use the json.org code in favor of it. The patch to bug 344640 is still using evalInSandbox.
(Reporter)

Comment 4

11 years ago
> Shaver is saying that evalInSandbox is not sufficient, and that we should use
> the json.org code in favor of it. The patch to bug 344640 is still using
> evalInSandbox.

If evalInSandbox isn't enough, we'll have to change the file format again. Anyway, I prefer having that discussion over in bug 344640.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
Flags: blocking-firefox2?
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.