Closed Bug 347078 Opened 14 years ago Closed 14 years ago

[SessionStore] Correctly JSON-ify the API

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED INVALID
Firefox 2 beta2

People

(Reporter: zeniko, Unassigned)

References

()

Details

Until bug 340987 gets fixed (which would make this dead-simple), we should probably fall back on using Douglas Crockford's toJSONString/parseJSON methods from http://www.json.org/json.js .
Requesting blocking, as bug 344640 can't move forward until this is addressed.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta2
Note that there is already a fully JSON-compliant patch attached to bug 344640 so this bug might get unnecessary soon.
(In reply to comment #2)
> Note that there is already a fully JSON-compliant patch attached to bug 344640
> so this bug might get unnecessary soon.
> 

Shaver is saying that evalInSandbox is not sufficient, and that we should use the json.org code in favor of it. The patch to bug 344640 is still using evalInSandbox.
> Shaver is saying that evalInSandbox is not sufficient, and that we should use
> the json.org code in favor of it. The patch to bug 344640 is still using
> evalInSandbox.

If evalInSandbox isn't enough, we'll have to change the file format again. Anyway, I prefer having that discussion over in bug 344640.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Flags: blocking-firefox2?
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.