Closed Bug 347084 Opened 19 years ago Closed 18 years ago

slow sqlite operations in nsUrlClassifierDBService can delay phishing checks or delay shutdown

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: tony, Assigned: tony)

Details

Bug 346940 adds support for full table reloads from the server. This is done by creating a temporary table to download new urls into, and once we finish the download, swap tables. The problem is that the swap step can be slow because there's no rename table operation in sqlite. One solution is to put each table into a separate file and just rename the files, which should be much faster (doesn't involve copying data).
Oh, the added benefit of this approach is that we also don't need to vacuum tables because we use a new db file for new tables.
sqlite does have a rename table operation. The vacuum benefit is discussed in bug 383031.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.