347092 - Value of MOZ_NO_REMOTE isn't tested

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[sendmail.to]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

We test only if a variable with the name MOZ_NO_REMOTE is set.
If MOZ_NO_REMOTE is 0 we shouldn't do the exactly same thing as if set to 1 or any other value.
http://lxr.mozilla.org/mozilla1.8.0/source/toolkit/xre/nsNativeAppSupportWin.cpp#629



Reproducible: Always

Comment 1

[Reed Loden [:reed]]

"The getenv() function returns the value of the environment variable as a NUL-terminated string.  If the variable name is not in the current environment, NULL is returned."

Basically you could do something like this:
  char *noremote = getenv("MOZ_NO_REMOTE");
  if (noremote && noremote[0] == '1') {
  ...

Of course, that will force MOZ_NO_REMOTE=1, breaking anybody that depends on just MOZ_NO_REMOTE or MOZ_NO_REMOTE=YES/TRUE/etc. I guess you could stricmp() on those values, but is it really worth it? (I bet there's something in the Mozilla codebase that can easily make boolean values out of C strings, but I don't know it off the top of my heads...) :]

Comment 2

[Benjamin Smedberg]

We should set no-remoting for any non-blank value of MOZ_NO_REMOTE

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> We should set no-remoting for any non-blank value of MOZ_NO_REMOTE

Isn't that what we do now (i.e. should this be marked WONTFIX)?