347158 - Dojo inlineEditBox crashes Firefox 2.0b when clicking cancel [@ mozInlineSpellChecker::SaveCurrentSelectionPosition]

Status: VERIFIED FIXED

(Core :: Spelling checker, defect)

Description

[Sebastian Schaffert]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; de; rv:1.8.1b1) Gecko/20060710 Firefox/2.0b1

When using Dojo's inlineEditBox and clicking "Cancel" afterwards (no change to the actual content), Firefox 2.0b1 crashes reproducibly with segmentation fault on Linux. The problem apparently only appears on paragraph/block-level elements (maybe those that are marked as "textarea" in Dojo), it seems to work on the header example.

Reproducible: Always

Steps to Reproduce:
1. click on the sample paragraph (not the header) to open a textarea for editing
2. click on cancel
3. boom

Actual Results:  
segmentation fault

Expected Results:  
not crash; textarea replaced by its contents

Comment 1

[Sebastian Schaffert]

I further examined the problem and it appears indeed to be connected with marking editable areas with ' mode="textarea" '. It works properly with normal input fields.

Comment 2

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060802 BonEcho/2.0b1 ID:2006080300

I see this too.

TB21734575E
TB21734542E

Talkback doesn't seem to be working atm, so I don't know what the stacktraces point to.

Comment 3

[Steve England [:stevee]]

This is also a regression, since the URL does not crash with
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

Comment 4

[Adam Guthrie]

Attachment: gdb stacktrace

Comment 5

[Martijn Wargers (dead)]

(For some reason I did not get a mail when I was cc-ed on this bug, I found this bug 'accidentally')
This was somehow fixed on trunk between 2006-08-02 and 2006-08-04.
I have good hope that this was fixed by one of the spell-checking patches that recently got in on trunk, but are not yet checked in on branch.
So hopefully, this will get fixed 'by itself' after a few days.
Please check again in a few days.

Comment 6

[Martijn Wargers (dead)]

Sebastian, Adam or Steve, is this still an issue with current branch build?

Comment 7

[Steve England [:stevee]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1 ID:2006081003
I am no longer seeing this crash.

Comment 8

[Brett Wilson]

Thanks, this was probably fixed by the recent crash fixes for the spellchecker.

Comment 9

[Jason Bassford]

Do you have a bug number for a spellcheck fix that fixed this one?  I see that bug 341058 was fixed by bug 325386...

Comment 10

[Brett Wilson]

Probably bug 232046 and bug 347561.

Comment 11

[Adam Guthrie]

Verified FIXED using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1b1) Gecko/20060810 BonEcho/2.0b1.

I no longer crash after clicking to edit the text and then clicking Cancel.