Closed Bug 347239 Opened 18 years ago Closed 18 years ago

Search engine updates fail if the engine name hasn't changed

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: pamg.bugs, Assigned: pamg.bugs)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Check for updates before checking for duplicate names
1.77 KB, patch
Gavin
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
A search-engine update that does not change the name of the engine is treated as a duplicate addition and not applied.  

The duplicate engine check in nsSearchService.js needs |&& !engineToUpdate| added to its test to fix the problem.  I expect to roll this fix into the patch for bug 339735.
Target Milestone: --- → Firefox 2 beta2
The one-line fix for this is part of the patch for bug 339735, but even if that doesn't make it into FF2, this part should.
Flags: blocking-firefox2?
Blocking on this to make sure it gets fixed.
Flags: blocking-firefox2? → blocking-firefox2+
This has already been reviewed by ben as part of the larger patch for bug 339735.  Additional comments are, of course, welcome.
Comment on attachment 233092 [details] [diff] [review]
Check for updates before checking for duplicate names

Please go ahead and land this on the trunk, and request branch approval. I think it's a good idea to split out the other sub-bugs fixed by the patch for bug 339735, to make that patch smaller and thus easier to review and to ensure that none of these are forgotten.
Attachment #233092 - Flags: review+
They've been split into this, bug 347950, and bug 348141.
(In reply to comment #5)
> They've been split into this, bug 347950, and bug 348141.

Yeah - by "splitting out" I meant splitting the patch and posting the seperate patches to the bugs, to be landed independently.
Working on it.  This was the first in line.
Landing on trunk to bake.
Whiteboard: [baking on trunk]
Comment on attachment 233092 [details] [diff] [review]
Check for updates before checking for duplicate names

This patch skips the test for a duplicate engine if the engine is being updated.  It is a low-risk patch with no l10n impact.
Attachment #233092 - Attachment description: Check for updates before checking for dupliacte names → Check for updates before checking for duplicate names
Attachment #233092 - Flags: approval1.8.1?
Comment on attachment 233092 [details] [diff] [review]
Check for updates before checking for duplicate names

a=drivers, please land on MOZILLA_1_8_BRANCH
Attachment #233092 - Flags: approval1.8.1? → approval1.8.1+
Landing on branch.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [baking on trunk]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: