Closed
Bug 347241
Opened 18 years ago
Closed 18 years ago
Don't use the DB to store engine order information unless the order is changed
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: Gavin, Assigned: Gavin)
Details
(Keywords: fixed1.8.1)
Attachments
(2 files, 1 obsolete file)
9.48 KB,
patch
|
mconnor
:
review+
mtschrep
:
approval1.8.1+
|
Details | Diff | Splinter Review |
1.14 KB,
patch
|
Details | Diff | Splinter Review |
To ensure that users who don't change the default engine order continue to receive the shipped default order regardless of the build they're using, we should only write engine ordering information to the DB if the user changes them, and fall back to the prefs otherwise.
Assignee | ||
Comment 1•18 years ago
|
||
I think this is all that's needed, but I need to look into this further.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•18 years ago
|
||
This makes us use the prefs unless an engine is moved, removed, or added. Making it only use the DB if the order changes is slightly more work. Benjamin, do you think this is sufficient?
Attachment #232007 -
Attachment is obsolete: true
Attachment #232044 -
Flags: review?(mconnor)
Assignee | ||
Comment 3•18 years ago
|
||
In addition to the reasons in comment 0, this patch makes it possible for the CCK to change the engine order on existing profiles, if the user hasn't modified, added or removed an engine.
Flags: blocking-firefox2?
Comment 4•18 years ago
|
||
Comment on attachment 232044 [details] [diff] [review] patch Yeah, good call. Thanks!
Attachment #232044 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 5•18 years ago
|
||
mozilla/browser/components/search/nsSearchService.js 1.67
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [baking]
Target Milestone: --- → Firefox 2 beta2
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [baking] → [needs approval]
Assignee | ||
Updated•18 years ago
|
Attachment #232044 -
Flags: approval1.8.1?
Comment 6•18 years ago
|
||
Comment on attachment 232044 [details] [diff] [review] patch a=schrep for drivers.
Attachment #232044 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Comment 7•18 years ago
|
||
mozilla/browser/components/search/nsSearchService.js 1.1.2.56
Keywords: fixed1.8.1
Whiteboard: [needs approval]
Assignee | ||
Comment 8•18 years ago
|
||
I landed this on the branch and trunk with r=mconnor.
You need to log in
before you can comment on or make changes to this bug.
Description
•