347241 - Don't use the DB to store engine order information unless the order is changed

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

To ensure that users who don't change the default engine order continue to receive the shipped default order regardless of the build they're using, we should only write engine ordering information to the DB if the user changes them, and fall back to the prefs otherwise.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: WIP

I think this is all that's needed, but I need to look into this further.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This makes us use the prefs unless an engine is moved, removed, or added. Making it only use the DB if the order changes is slightly more work. Benjamin, do you think this is sufficient?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

In addition to the reasons in comment 0, this patch makes it possible for the CCK to change the engine order on existing profiles, if the user hasn't modified, added or removed an engine.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 232044 [details] [diff] [review]
patch

Yeah, good call.  Thanks!

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.67

Comment 6

[Mike Schroepfer]

Comment on attachment 232044 [details] [diff] [review]
patch

a=schrep for drivers.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.56

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: typo fix

I landed this on the branch and trunk with r=mconnor.