Right now checksetup.pl has a block of code to create the default product. This should be moved into a module. Also, it exists *before* the table changes, when really it should exist *after* the table changes. I checked all the table changes, they don't depend on us having a default product already in place. So there's no reason for it to be where it is.
Created attachment 232061 [details] [diff] [review] v1 Okay, here it is. I also made the code use Bugzilla::Product and Bugzilla::Version and all that as much as possible. I also had to add some sensible defaults to the products table that I should have added long ago, for PostgreSQL. We'll need these anyway, if we ever make Bugzilla::Product implement Bugzilla::Object->create.
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Requesting approval directly, as module owner.
Checking in checksetup.pl; /cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v <-- checksetup.pl new revision: 1.536; previous revision: 1.535 done Checking in Bugzilla/Install.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install.pm,v <-- Install.pm new revision: 1.2; previous revision: 1.1 done Checking in Bugzilla/DB/Schema.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v <-- Schema.pm new revision: 1.58; previous revision: 1.57 done Checking in Bugzilla/Install/DB.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v <-- DB.pm new revision: 1.4; previous revision: 1.3 done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.