347364 - Allow extensions to add searchplugins at an arbitrary position in the list

Status: RESOLVED FIXED

(Firefox :: Search, enhancement)

Description

[Benjamin Smedberg]

Currently extensions can add a searchplugin at the top of the list by setting the browser.search.order.1 pref. This is a little unfortunate because it doesn't "push down" the defaults by one. We can fix this by using a prefbranch:

pref("browser.search.order.extra.seznam", "Seznam");

This will push Seznam to the top of the list.

Comment 1

[Benjamin Smedberg]

Attachment: Read .extra.* prefs, rev. 1

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 232145 [details] [diff] [review]
Read .extra.* prefs, rev. 1

>Index: browser/components/search/nsSearchService.js

>+      try {
>+        var prefB = Cc["@mozilla.org/preferences-service;1"].
>+          getService(Ci.nsIPrefBranch);

nit: line up the "getService" with the "Cc" to match this file's style.

Comment 3

[Benjamin Smedberg]

Fixed on trunk.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 232145 [details] [diff] [review]
Read .extra.* prefs, rev. 1

a=drivers, although we wonder what happens when you get two extensions that try to do this. alphabetical? most-recently-added extension wins?

Comment 5

[Benjamin Smedberg]

the two get added at the top of the list, but it's random which one wins

Comment 6

[Benjamin Smedberg]

Fixed on MOZILLA_1_8_BRANCH