Command-dragging a background window should not activate it

VERIFIED FIXED in M18

Status

()

Core
XUL
P4
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: Simon Fraser, Assigned: Simon Fraser)

Tracking

({helpwanted, polish})

Trunk
PowerPC
Mac System 8.5
helpwanted, polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [nsbeta3+][p:4]fix in hand)

(Assignee)

Description

18 years ago
If you command-drag a background window, it should not be activated (brought to 
the front) when the drag is complete.
dan, you're doing work in this general area, right? reassign back to me if you 
disagree.
Assignee: pinkerton → danm

Updated

18 years ago
Target Milestone: --- → M17

Comment 2

18 years ago
moving to m18
Target Milestone: M17 → M18

Comment 3

18 years ago
mass-moving all bugs to m21 that are not dofood+, or nsbeta2+
Target Milestone: M18 → M21

Updated

18 years ago
Target Milestone: M21 → Future
(Assignee)

Comment 4

18 years ago
*sigh* every Mac app on the planet does this.
Keywords: 4xp, correctness, helpwanted, polish
(Assignee)

Comment 5

18 years ago
Here's the fix:

Index: mozilla/widget/src/mac/nsMacMessagePump.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsMacMessagePump.cpp,v
retrieving revision 1.103
diff -r1.103 nsMacMessagePump.cpp
498,501c498,505
< 				nsMacWindow *mw = mMessageSink->
GetNSWindowFromMacWindow(whichWindow);
< 				if (mw)
< 					mw->ComeToFront();
< 
---
>         // only activate if the command key is not down
>         if (!(anEvent.modifiers & cmdKey))
>         {
>           nsMacWindow *mw = mMessageSink->GetNSWindowFromMacWindow(whichWindow);
>           if (mw)
>             mw->ComeToFront();
>         }
>         
Assignee: danm → sfraser
Keywords: nsbeta3, patch
Whiteboard: fix in hand
Target Milestone: Future → M18

Comment 6

18 years ago
I was going through my bugzilla emails and when I saw that this bug was future'd, 
I had the same reaction as you. Some things take less time to fix than to move 
around.

Comment 7

18 years ago
setting to nsbeta3+ -- get the fix in
Keywords: 4xp
Priority: P3 → P4
Whiteboard: fix in hand → [nsbeta3+][p:4]fix in hand
(Assignee)

Comment 8

18 years ago
I fixed this.
(Assignee)

Comment 9

18 years ago
Fixed
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 10

18 years ago
I verified this ( build 2000091304m18). Background window no longer activates 
when command-dragged.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.