Closed Bug 347406 Opened 18 years ago Closed 18 years ago

"Advanced" and "Privacy" panels icons have wrong image region / "Privacy" and "Security" icons are swapped

Categories

(Firefox :: Settings UI, defect)

Product:
Firefox
Component:
Settings UI
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: regis.caspar+bz, Assigned: regis.caspar+bz)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])

Attachments

(3 files)

screenshot
22.00 KB, image/png
Details
patch v1
1.66 KB, patch
mconnor
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review
patch v1 result (screenshot)
25.34 KB, image/png
Details 
Following new theme landing, in Options window, "Advanced" and "Privacy" panels have wrong image region resulting in some small thing on the right of the "Advanced" icon and "Privacy" is cropped on left.

Additionally, "Privacy" and "Security" icons are swapped.

Will attach screenshot.
Attached image screenshot — 

    
    

    
  
I forgot my user agent-string: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1 ID:2006080409

Sorry.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1
        — 
          — Splinter Review
      

    


  
This patch fix:
- "Privacy" and "Security" icons swap
- -moz-image-region of "Security" and "Advanced"
- incoherences in :hover and [selected="true"] rule for "Feeds"
Assignee: nobody → regis.caspar+bz
Status: NEW → ASSIGNED

        Attachment #232292 -
        Flags: review?

    
  

        Attachment #232292 -
        Flags: review? → review?(mconnor)

    
    

    
  


  
Screenshot showing result of patch v1
Flags: blocking-firefox2+
Whiteboard: [Fx2 theme change]

    
    

    
  
Comment on attachment 232292 [details] [diff] [review]
patch v1

r+a=me for 1.8.1 branch checkin

        Attachment #232292 -
        Flags: review?(mconnor)

        Attachment #232292 -
        Flags: review+

        Attachment #232292 -
        Flags: approval1.8.1+

    
    

    
  
mozilla/browser/themes/winstripe/browser/preferences/preferences.css 	1.6.8.6
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 2 beta2

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: