34741 - Should be able to command-drag background windows when a dialog is up

Status: VERIFIED FIXED

(Core :: XUL, defect, P4)

Description

[Simon Fraser [no longer active]]

It should be possible to command-drag background windows when a dialog is up. The 
dialog event handler seems to be blocking more events than it should right now.

Comment 1

[Peter Trudelle]

mass-moving all bugs to m21 that are not dofood+, or nsbeta2+

Comment 2

[Simon Fraser [no longer active]]

Here's the fix:

Index: mozilla/widget/src/mac/nsWindow.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsWindow.cpp,v
retrieving revision 1.159
diff -r1.159 nsWindow.cpp
402,403c402,403
< 		WindowPtr window = (WindowPtr) GetNativeData(NS_NATIVE_DISPLAY),
< 		          rollupWindow = gRollupWidget ? (WindowPtr) gRollupWidget->
GetNativeData(NS_NATIVE_DISPLAY) : 0;
---
> 		WindowPtr window = (WindowPtr) GetNativeData(NS_NATIVE_DISPLAY);
> 		WindowPtr rollupWindow = gRollupWidget ? (WindowPtr) gRollupWidget->GetNativeData(NS_NATIVE_DISPLAY) : nsnull;
404a405
> 		
406c407
< 		bool inWindow = eventWindow && (eventWindow == window || eventWindow == 
rollupWindow);
---
> 		PRBool inWindow = eventWindow && (eventWindow == window || eventWindow == rollupWindow);
418,420c419,422
< 				if ( inWindow &&
< 				     ( where == inContent || where == inDrag || where == 
inGrow ||
< 				       where == inGoAway || where == inZoomIn || where == 
inZoomOut ))
---
> 				if (inWindow)
> 				{
> 				     if ( where == inContent || where == inDrag   || where == inGrow ||
> 				          where == inGoAway  || where == inZoomIn || where == inZoomOut )
421a424,437
> 				}
> 				else      // we're in another window.
> 				{
> 				  // let's handle dragging of background windows here
> 				  if (eventWindow && (where == inDrag) && (theEvent->modifiers & cmdKey))
> 				  {
>     				Rect screenRect;
>     				::GetRegionBounds(::GetGrayRgn(), &screenRect);
> 				    ::DragWindow(eventWindow, theEvent->where, &screenRect);
> 				  }
> 				  
>   				*aForWindow = PR_FALSE;
> 				}
> 				

Comment 3

[rubydoo123]

setting to nsbeta3+ - get the fix in

Comment 4

[Simon Fraser [no longer active]]

Fix checked in.

Comment 5

[Simon Fraser [no longer active]]

Ooops, closed the wrong bug. This is yet to be reviewed and checked in.

danm, can you review the patch?

Comment 6

[Simon Fraser [no longer active]]

Fix checked in.

Comment 7

[shrirang khanzode]

I verified this (build 2000091304m18). Can command drag backgrnd windows with a 
dialog up.