347410 - 2.0 Theme Bug -- report site toolbar icon needs more padding

Status: RESOLVED WORKSFORME

(Other Applications Graveyard :: Reporter, defect)

Description

[David Miller]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1

changing the size of "report site" to small causes it to scale improperly, especially if the icon is placed between the "GO" button and the address bar.

Reproducible: Always

Steps to Reproduce:
1. place your "report site" icon between "GO" and address bar
2. change size to small icons


Actual Results:  
icon scales, but scales without borders above/below it.

Expected Results:  
should scale properly

extremely trivial.

Comment 1

[David Miller]

Attachment: boog

Comment 2

[Jackie Liu]

I can reproduce this on the same build you're using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060804 BonEcho/2.0b1.  Actually, even without selecting "Use Small Icons", there is no borders to the right of the icon.  Other icons behave properly.

Comment 3

[David Miller]

I changed the description.  It's more indicative of the behavior being experienced now since it is not limited to one particular icon rather; all of them.

Comment 4

[Dave Townsend [:mossop]]

The icon needs more padding on the left and right sure, but I don't see what the problem with scaling is. And I don't see any scaling problem with other icons either.

Comment 5

[Jackie Liu]

No.  I think you have misunderstood me, David.  All other icons scale properly.  Only the "Report Site" icon has the problem.

Comment 6

[David Miller]

(In reply to comment #5)
> No.  I think you have misunderstood me, David.  All other icons scale properly.
>  Only the "Report Site" icon has the problem.
> 

Yeah, I did misunderstand.  My fault :-(

Comment 7

[Jackie Liu]

Also, if the "Report Site" icon is on the very end of the toolbar, there's no padding on the right side.

Comment 8

[Dave Townsend [:mossop]]

At large size the icon has padding on the left. At small it has no padding at all.

Comment 9

[Jackie Liu]

I've been playing around with this bug again in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1.  Now, there's no padding on the left regardless of small or large icons.  The top, right, and bottom padding seems to be okay.

Comment 10

[Jackie Liu]

Sorry I goofed.  I mean there's no padding on the left regardless of large or small icons.  The right, top, and bottom seems to be OK.

  

Comment 11

[Jackie Liu]

Really sorry for the mistakes.  I made a mistake in comment #9 today, then made the same mistake in comment #10 which was supposed to be a correction for comment #9. Please forget comment #9 and #10.

OK, let me get this straight.  I mean there's no padding on the *right* regardless of large or small icons.  The right, top, and bottom padding seems to be OK.  Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060815 BonEcho/2.0b1.

Comment 12

[Dave Townsend [:mossop]]

I would expect this to be cleared up by bug 348436

Comment 13

[Adam Guthrie]

This appears to be fixed now. Marking WFM.