347415 - Accesskey for "Proportional" is not displayed in the advanced preference font panel

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Cédric Corazza]

When going in Preferences > Content > Advanced button (in the Fonts & Colors groupbox), the accesskey for 'Proportional' isn't displayed i.e the letter P is not underlined. I watched in the fonts.xul file and though the syntax is correct, I noticed a difference between the Suite code (in SeaMonkey, the letter P is underlined) and Firefox code :
this line in firefox is coded this way :
<label accesskey="&proportional.accesskey;" control="proportionalFont">&proportional.label;</label>
and that way in the Suite :
<label value="&proportional.label;" accesskey="&proportional.accesskey;" control="proportionalFont"/>
Do you think this could be the reason?
I'm waiting for your comments before attaching a patch and filing the same bug for Thunderbird.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Same thing in the pl locale.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Does that change fix it? :)

Comment 3

[Cédric Corazza]

Gavin,
I'm not a coder, I was just asking if what i proposed is the good fix ;)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I'm just asking whether that change actually fixes the bug - from your comment it seems like you weren't sure.

Comment 5

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

The bug also occurs on trunk. It's a regression from bug 283678, which changed
the menulist id a few lines down without changing the "control" attribute.

Comment 6

[[e-mail]]

Comment on attachment 232261 [details] [diff] [review]
Patch rev. 1

not a browser/ peer

Comment 7

[Cédric Corazza]

I filed the equivalent bug for Thunderbird (bug347519)

Comment 8

[Asaf Romano (gone)]

Comment on attachment 232261 [details] [diff] [review]
Patch rev. 1

r=mano (you don't need sr= in browser/toolkit).

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 232261 [details] [diff] [review]
Patch rev. 1

a=beltzner on behalf of 181drivers

Comment 10

[Mats Palmgren (inactive)]

Landed on trunk and MOZILLA_1_8_BRANCH at 2006-09-01 06:46 PDT.

-> FIXED