Closed
Bug 347457
Opened 18 years ago
Closed 18 years ago
If a readonly engine has updates, and the icon load callback runs first, an exception is thrown
Categories
(Firefox :: Search, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: Gavin, Assigned: Gavin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.93 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
This is the cause of http://forums.mozillazine.org/viewtopic.php?p=2412032#2412032 . We should not even try to update read-only engines.
|
Assignee | |
Comment 1•18 years ago
|
||
The problem is that we're starting an update load for a readonly engine, and the icon load callback doesn't check whether the engine is readonly before trying to write to the file, but the file load callback does. Instead of checking in both callbacks, this just refuses to start an engine update load if the engine is readonly.
|
|
Assignee | |
Updated•18 years ago
|
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta2
|
|
Assignee | |
Updated•18 years ago
|
Summary: If a readonly engine has updates, and the icon load callback loads first, an exception is thrown → If a readonly engine has updates, and the icon load callback runs first, an exception is thrown
|
||
Updated•18 years ago
|
Attachment #232228 -
Flags: review?(mconnor) → review+
|
|
||
Updated•18 years ago
|
Attachment #232228 -
Flags: approval1.8.1+
|
|
||
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 2•18 years ago
|
||
mozilla/browser/components/search/nsSearchService.js 1.1.2.57 mozilla/browser/components/search/nsSearchService.js 1.69
You need to log in
before you can comment on or make changes to this bug.
Description
•