347531 - [Mac] Pinstripe toolbar icons are the wrong size

Status: RESOLVED INVALID

(Firefox :: Theme, defect)

Description

[Kevin Gerich]

The visual refresh included Mac toolbar icons that are 24x24 for the large icons and 16x16 for the small.

The convention for Aqua apps is 32x32 for the large icons and 24x24 for the small. If the aim is to make the default toolbar appear smaller, let's tweak the default profile to use small icons instead.

Comment 1

[Mike Connor [:mconnor]]

We should really discuss this.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

I agree, this is worth considering for a post beta2 issue.

Jay, you'd mentioned during the design phase that the icons were 24x24 because that was the route that most mac apps were taking. I've heard a lot of people say both "the new small icons on Mac suck" (they are a little wee) and "don't take away my ability to use small icons". This seems like an only mildly ingenuous way of solving both problems at the same time!

Comment 3

[Jay Goldman]

We went with 24 x 24 for a few reasons:

- There's no consistency whatsoever in Mac apps as to toolbar button size. Apple's apps are all over the map, though they're starting to settle on the new style seen in Mail.app. Their trend is towards smaller buttons which give more space for content in the browser (Mail's standalone buttons are 41 x 22, Safari's are 28 x 25). Given that there was no real precedent, we didn't feel a compelling need to stay with "large" 32 x 32 icons when 24 x 24 was able to easily display the same amount of information in less space.

- The Winstripe icons are 24 x 24, which made it much easier for us to create the full set of both icons by using similar elements with different style treatments. This is true for all extension developers too - they can get away with a single set of 24 x 24 icons, or can build ones per platform if they want.

- Our small icons on Pinstripe are 16 x 16, but it looks like they are more spaced out which might make them appear smaller.

Since I'm hard pressed to find a recent Mac application that uses 32 x 32 icons, I think this bug is basically saying that the icons are smaller than they were in 1.5, which is true! :) Going to 16 x 16 by default doesn't seem like the right move to me.

Comment 4

[Mike Connor [:mconnor]]

open design decision -> beltzner

Comment 5

[mark]

safari and mail are different things. they have some kind of bubble style buttons. and those in 24'24 size would look too big.
its clear that new theme has way too small icons. the space area win isnt that huge in my opinion.

you should still conclude on mac os x style. the same thing is with search bar. search bar is in EVERY application white one with gray icon. it should be the same in firefox. the goal was os-like theme...

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This won't block the release.

Comment 7

[Peter Kasting]

Is this WONTFIX at this point, or is the question still open on the trunk?  Obviously, this isn't going to change in Firefox 2.

Comment 8

[mark]

strange approach

Comment 9

[mark]

Okay. Thats should be a bit more convincing:

1. Open some tabs. 3-...
2. Enable bookmarks bar
3. And now check the priorities, the look! If the icons would be in standard size then the look would be pretty much different.

Safari has other style buttons and much lower tabs.

Voting!

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #0)
> The convention for Aqua apps

... don't matter anymore.