bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Missing accesskeys in font pref panel

VERIFIED FIXED in Thunderbird2.0

Status

Thunderbird
Preferences
--
trivial
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Cédric Corazza, Assigned: Cédric Corazza)

Tracking

({access, fixed1.8.1})

Thunderbird2.0
access, fixed1.8.1

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
There are two missing accesskeys for "Size (pixels)" in Edition > Preferences > Display > Fonts tab > Fonts... button.
I think there should be ones, as it is the case for Firefox for the same panel.
Patch follows
(Assignee)

Comment 1

12 years ago
Created attachment 232341 [details] [diff] [review]
Patch adding accesskeys for "Size (pixels)" labels
Attachment #232341 - Flags: review?(mscott)
Attachment #232341 - Flags: approval-thunderbird2?

Comment 2

12 years ago
Comment on attachment 232341 [details] [diff] [review]
Patch adding accesskeys for "Size (pixels)" labels

Thanks for the patch cedric. How about re-naming the access keys to be more specific. Instead of size1.accessey and size2.accesskey make it something like

proportionalSize.accesskey
and
monospaceSize.accesskey

I'll plus the patch if you make that change for me. Thanks!
Attachment #232341 - Flags: review?(mscott)
Attachment #232341 - Flags: review-
Attachment #232341 - Flags: approval-thunderbird2?
(Assignee)

Comment 3

12 years ago
No problem. Will do this tomorrow. I just reproduced the pattern used for Firefox.
(Assignee)

Comment 4

12 years ago
Created attachment 232682 [details] [diff] [review]
Patch addressing comment #2
Attachment #232341 - Attachment is obsolete: true
Attachment #232682 - Flags: review?(mscott)

Comment 5

12 years ago
Comment on attachment 232682 [details] [diff] [review]
Patch addressing comment #2

awesome, thanks a lot for fixing that.
Attachment #232682 - Flags: review?(mscott)
Attachment #232682 - Flags: review+
Attachment #232682 - Flags: approval-thunderbird2+

Comment 6

12 years ago
Note the related patch at bug 347519.
Severity: normal → trivial
OS: Linux → All
Hardware: PC → All
Version: unspecified → 1.5
(Assignee)

Updated

12 years ago
Whiteboard: [checkin-needed]
(Assignee)

Comment 7

12 years ago
Hi,
Could someone check this in please as this bug got all the needed approvals?
Thanks

Updated

12 years ago
Whiteboard: [checkin-needed] → [checkin needed]
Assignee: mscott → cedric.corazza
mozilla/mail/components/preferences/fonts.xul 	1.9
mozilla/mail/locales/en-US/chrome/messenger/preferences/fonts.dtd 	1.6
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [checkin needed (1.8 branch)]
mozilla/mail/locales/en-US/chrome/messenger/preferences/fonts.dtd 	1.3.2.3
mozilla/mail/components/preferences/fonts.xul 	1.4.2.5
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: --- → Thunderbird2.0

Comment 10

12 years ago
V with TB 2b1-1018, Win2K.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.