347554 - compose window recycling broken, exception terminates gComposeRecyclingListener.onClose

Status: RESOLVED DUPLICATE of bug 282669

(Thunderbird :: Message Compose Window, defect)

Description

[Kai Engert (:KaiE:)]

Linux. Mozilla 1.8 branch. Thunderbird.

Mail Message Compose Window Recycling is broken.
An exception happens during execution of gComposeRecyclingListener.onClose
This causes function to terminate without completing.
This causes at least bug 345784, where the encryption/signing flags can no longer be controlled in follow up messages.
I expect this causes other failures in recycled compose windows as well.

The exact message I get is:

Error: top.awInputElement has no properties
Source File: chrome://messenger/content/messengercompose/MsgComposeCommands.js
Line: 196

The Error message and source file is correct.
I was able to "hide" this bug by wrapping access to this code
    if (top.awInputElement.getAttribute('focused') != '')
      top.awInputElement.removeAttribute('focused');
in a try/catch block (see also attached patch).

It was confusing that the error message lists lines number 196, although this code is really located at lines 232/233. (This incorrect line number might be another bug in JS error reporting???)

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Patch v1 - hides problem

Not sure if this is the right solution to the problem, but at least this patch hides the bug.

Comment 2

[Kai Engert (:KaiE:)]

Thanks to Neil who told me, this is a duplicate of bug 282669.
The patch in that bug will be checked in now.


*** This bug has been marked as a duplicate of 282669 ***

Comment 3

[Scott MacGregor]

Comment on attachment 232349 [details] [diff] [review]
Patch v1 - hides problem

canceling a review request, I don't think we need this anymore.