Closed Bug 347568 Opened 18 years ago Closed 18 years ago

"No updates were found" bar should be dismissed when you change view

Categories

(Toolkit :: Add-ons Manager, defect)

x86
Windows XP
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.8.1beta2

People

(Reporter: wgianopoulos, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.8.1, polish)

Attachments

(1 file)

It is possible, with the add-ons manager, to have both the "No updates were found" bar displayed as well as a list of updates that can be installed.  Obviously this should not happen.

Steps to reproduce:

1.  Make sure all of your themes are up-to-date.
2.  Make sure you have at least one extension for which "find Updates" will find a newer version.
3.  Go to Tools ->  Add-ons -> Themes.
4.  Click on "Find Updates"
5.  When the "No updates were found" bar appears, do not close it.
6.  Select Extensions.
7.  Click on "Find updates.

This will result in both the "No updates were found" bar being displayed at the same time a list of available extension updates is shown.

The simple fix here would be to dismiss the "No updates were found" bar when you click on "Find Updates".
Severity: normal → trivial
Keywords: polish
I think it makes more sense to dismiss it when the view is changed since showing no updates for a view that hasn't been checked also doesn't make sense. This will need some significant tweaking of the addonsmessage binding to accomplish.
Summary: "No updates were found" bar should be dismissed when you click on "find Updates" → "No updates were found" bar should be dismissed when you change view
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #232511 - Flags: review?(sspitzer)
(In reply to comment #1)
> I think it makes more sense to dismiss it when the view is changed since
> showing no updates for a view that hasn't been checked also doesn't make sense.
> This will need some significant tweaking of the addonsmessage binding to
> accomplish.
> 
I suppose that is true, but that only fixes one of the ways you can get in the "No updates found" and updates displayed condition.  The other would be if you searched for updates and did not find any, perhaps because your wireless connection dropped or whatever.  SO, you fix that and then click on find updates again and some are found. 

Comment on attachment 232511 [details] [diff] [review]
patch - listen for command events

This actually handles that case and the view change case... the one case I know of that it doesn't handle is when there is a no updates found message and an install is initiated from a web page.
Attachment #232511 - Flags: review?(sspitzer)
(In reply to comment #4)
> (From update of attachment 232511 [details] [diff] [review] [edit])
> This actually handles that case and the view change case... the one case I know
> of that it doesn't handle is when there is a no updates found message and an
> install is initiated from a web page.
> 
So it does.  Just tested with the patch.  Works great for me!
Comment on attachment 232511 [details] [diff] [review]
patch - listen for command events

This handles the majority of the cases and I'd like to get this for 1.8.1 if possible
Attachment #232511 - Flags: review?(benjamin)
Attachment #232511 - Flags: review?(benjamin) → review+
Checked in to trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #232511 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Comment on attachment 232511 [details] [diff] [review]
patch - listen for command events

a=drivers, please land on the branch.
Attachment #232511 - Flags: approval1.8.1? → approval1.8.1+
Checked in to MOZILLA_1_8_BRANCH
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Target Milestone: --- → Firefox 2 beta2
I have no idea what is going on here but this seems to be broken again both branch and trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Bug 353918 has been opened to address this issue.
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: