Closed Bug 347583 Opened 18 years ago Closed 18 years ago

Theme preview on Linux has incorrect background color and mgr. lists don't have borders

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.8 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1beta2

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.8.1, polish)

Attachments

(3 files, 2 obsolete files)

xpinstall before and after screenshot
65.19 KB, image/png
Details
add-ons mgr before and after screenshots
137.04 KB, image/png
Details
patch - also fixes borders for linux (win32 looks the same)
2.59 KB, patch
robert.strong.bugs
: review+
dbaron
: approval1.8.1+
Details | Diff | Splinter Review 
screenshots and patch coming up
Attached patch patch (obsolete) — — Splinter Review 

        Attachment #232392 -
        Flags: review?(sspitzer)
Keywords: polish
Version: Trunk → 2.0 Branch

        Attachment #232392 -
        Flags: review?(sspitzer) → review?(gavin.sharp)

    
    

    
  
This is essentially the same as bug 310113 except for the theme preview area

    
    

    
  
Comment on attachment 232392 [details] [diff] [review]
patch

r=me, but you may want to copy over some of the style rules from http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/listbox.css&rev=1.9#47 too, to get a full "listbox" styling.

        Attachment #232392 -
        Flags: review?(gavin.sharp) → review+

    
    

    
  
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

added border styling per comment #4. carrying forward r+

        Attachment #232468 -
        Flags: review+

    
    

    
  
Should the richlistbox rules be in xul.css?

    
    

    
  
I don't believe so. These are theme specific and it should be possible to over-ride them with the theme.

    
    

    
  
Also, -moz-appearance: listbox IMO should pick up the styling as it does for win32 but with 2.0 around the corner I don't have time to figure out why it doesn't.
Summary: Theme preview on Linux has incorrect background color → Theme preview on Linux has incorrect background color and mgr. lists don't have borders

    
    

    
  
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

simple polish fix to make the add-ons mgr. and xpinstall dialog look decent on linux.

        Attachment #232468 -
        Flags: approval1.8.1?

    
    

    
  
(In reply to comment #10)
> I don't believe so. These are theme specific and it should be possible to
> over-ride them with the theme.

Duh, I meant toolkit/themes/winstripe/global/richlistbox.css, not xul.css.

    
    

    
  
I really could go either way on that since it appears that anything with -moz-appearance: listbox doesn't get styled with the background-color, color, or border as it does for win32.

    
    

    
  
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

a=dbaron on behalf of drivers.  Please land on MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword once you have done so.

        Attachment #232468 -
        Flags: approval1.8.1? → approval1.8.1+

    
    

    
  
Checked in to MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Toolkit

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: