Theme preview on Linux has incorrect background color and mgr. lists don't have borders

RESOLVED FIXED in mozilla1.8.1beta2

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: rstrong, Assigned: rstrong)

Tracking

({fixed1.8.1, polish})

1.8 Branch
mozilla1.8.1beta2
x86
Linux
fixed1.8.1, polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

screenshots and patch coming up
Created attachment 232391 [details]
before and after screenshots
Keywords: polish
Version: Trunk → 2.0 Branch
Attachment #232392 - Flags: review?(sspitzer) → review?(gavin.sharp)
This is essentially the same as bug 310113 except for the theme preview area
Comment on attachment 232392 [details] [diff] [review]
patch

r=me, but you may want to copy over some of the style rules from http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/themes/winstripe/global/listbox.css&rev=1.9#47 too, to get a full "listbox" styling.
Attachment #232392 - Flags: review?(gavin.sharp) → review+
Created attachment 232451 [details]
xpinstall before and after screenshot
Created attachment 232453 [details]
add-ons mgr before and after screenshots
Attachment #232391 - Attachment is obsolete: true
Created attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)
Attachment #232392 - Attachment is obsolete: true
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

added border styling per comment #4. carrying forward r+
Attachment #232468 - Flags: review+
Should the richlistbox rules be in xul.css?
I don't believe so. These are theme specific and it should be possible to over-ride them with the theme.
Also, -moz-appearance: listbox IMO should pick up the styling as it does for win32 but with 2.0 around the corner I don't have time to figure out why it doesn't.
Summary: Theme preview on Linux has incorrect background color → Theme preview on Linux has incorrect background color and mgr. lists don't have borders
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

simple polish fix to make the add-ons mgr. and xpinstall dialog look decent on linux.
Attachment #232468 - Flags: approval1.8.1?
(In reply to comment #10)
> I don't believe so. These are theme specific and it should be possible to
> over-ride them with the theme.

Duh, I meant toolkit/themes/winstripe/global/richlistbox.css, not xul.css.
I really could go either way on that since it appears that anything with -moz-appearance: listbox doesn't get styled with the background-color, color, or border as it does for win32.
Comment on attachment 232468 [details] [diff] [review]
patch - also fixes borders for linux (win32 looks the same)

a=dbaron on behalf of drivers.  Please land on MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword once you have done so.
Attachment #232468 - Flags: approval1.8.1? → approval1.8.1+
Checked in to MOZILLA_1_8_BRANCH
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.