347678 - nsMsgDatabase leaks an nsMdbFactory on shutdown

Status: RESOLVED DUPLICATE of bug 388101

(MailNews Core :: Database, defect)

Description

[Adam Guthrie]

Found using the trace refcount logs.

gMDBFactory is declared here but never released in the descrutor: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/db/msgdb/src/nsMsgDatabase.cpp&rev=1.367&mark=991#987.

nsMsgFolderCache gets around this by declaring the variable right above the destructor and then releasing it in the descructor: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mailnews/base/src/nsMsgFolderCache.cpp&rev=1.48&mark=63,72-75#61.

We can do this in nsMsgDatabase, but it just feels weird since it's such a big file...

Comment 1

[Adam Guthrie]

Attachment: hack

Comment 2

[Adam Guthrie]

nsAddrDatabase needs to be fixed, too.

Comment 3

[Adam Guthrie]

What do you think, David? Is declaring the variable above the destructor like this acceptable, or does it need to become a member variable somehow?

Comment 4

[Adam Guthrie]

Can someone explain to me why GetMDBFactory is even a static method?

Comment 5

[Mark Banner (:standard8)]

This has been fixed by bug 388101. Marking as duplicate.