Closed Bug 347686 Opened 18 years ago Closed 18 years ago

log autocomplete actions

Categories

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Product:
Toolkit Graveyard
Component:
Data Collection/Metrics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

References

Details

Attachments

(2 files, 1 obsolete file)

log text-entered events
16.35 KB, patch
Details | Diff | Splinter Review
better logging fix
4.15 KB, patch
Details | Diff | Splinter Review 
We should be able to log autocomplete actions, such as:
 - textentered (with its associated autocomplete index)
 - textreverted
Depends on: 347687

        Attachment #232828 -
        Flags: first-review?(marria)

    
    

    
  
Comment on attachment 232828 [details] [diff] [review]
log text-entered events

Could you just add a high level comment explaining the general approach?  Otherwise looks good

        Attachment #232828 -
        Flags: first-review?(marria) → first-review+

    
    

    
  
Expanded the comment in nsAutoCompleteCollector.h, and checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  

      
      
      
      

        Attached patch
          
          
        add missing #define (obsolete)
        — 
          — Splinter Review
      

    


  
Make this collector consistent with the others so that MS_LOG works in release builds.

        Attachment #235362 -
        Flags: first-review?(marria)

    
    

    
  


  
The makefile test is kind of hacky, but it'll work without changing the toplevel configure file, which I'd bet is fairly locked down on the branch.

        Attachment #235362 -
        Attachment is obsolete: true

        Attachment #235368 -
        Flags: first-review?(marria)

        Attachment #235362 -
        Flags: first-review?(marria)

    
  

        Attachment #235368 -
        Flags: first-review?(marria) → first-review+

    
    

    
  
checked in the missing nsMetricsModule.cpp change from attachment 232828 [details] [diff] [review]

    
  
Flags: first-review+
Product: Toolkit → Toolkit Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: