Closed Bug 347719 Opened 19 years ago Closed 19 years ago

Live bookmark icon is squished

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: mossop, Assigned: mconnor)

References

Details

(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])

Attachments

(2 files)

Winstripe: fixes the feed button to use the right image
2.20 KB, patch
Details | Diff | Splinter Review
the right fix
2.07 KB, patch
beltzner
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
At first I thought this was a neat new icon but I now think that this is accidental. The live bookmark icon when shown on the bookmarks toolbar is squished. The image region it is displaying is 18x18 but the icon is forced down to 16x16.
Assignee: nobody → jgoldman
Flags: blocking-firefox2+
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2 beta2
Attached patch the right fix — — Splinter Review
So, this cleans up Jay's fix from Bug 347435 to use 16px image regions on the bookmark toolbar, and seems to be correct. Jay's patch here changes the URL bar feed button, which was a different (and now fixed) bug.
Assignee: jgoldman → mconnor
Status: NEW → ASSIGNED
Attachment #233539 - Flags: review?(mconnor)
Comment on attachment 233725 [details] [diff] [review] the right fix r/a=beltzner
Attachment #233725 - Flags: review+
Attachment #233725 - Flags: approval1.8.1+
Keywords: fixed1.8.1
Since this was landed on branch and didn't affect trunk, ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: