msie tridentprofile importer doesn't build on linux

NEW
Assigned to

Status

()

Toolkit
Startup and Profile System
--
trivial
12 years ago
10 years ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Yes, we know this is not quite sensible. but the code at least *thinks* about doing this and so, it should either think *harder* or less hard.

romaxa@romaxa-sr:/home/work/xulrunner/maemo-browser/build-tree/mozilla/debug-i686-pc-linux-gnu/extensions/tridentprofile$ make -s
nsTridentProfileMigrator.o: In function `nsTridentProfileMigrator::MigrateTridentProfile(unsigned int)':
/home/work/xulrunner/maemo-browser/build-tree/mozilla-cvs-20060803.0/extensions/tridentprofile/src/nsTridentProfileMigrator.cpp:69: undefined reference to `MakeTridentPreferences()'
collect2: ld returned 1 exit status
make[2]: *** [libtridentprofile.so] Error 1
make[1]: *** [libs] Error 2
make: *** [all] Error 2
romaxa@romaxa-sr:/home/work/xulrunner/maemo-browser/build-tree/mozilla/debug-i686-pc-linux-gnu/extensions/tridentprofile$ ls src/
Makefile  nsModule.o  nsTridentProfileMigrator.o

This is of course because the makefile looks like this:

ifeq ($(MOZ_WIDGET_TOOLKIT),windows)
CPPSRCS += nsTridentPreferencesWin.cpp
endif
(Assignee)

Comment 1

12 years ago
Created attachment 232528 [details] [diff] [review]
this will work most of the time
(Assignee)

Updated

12 years ago
Attachment #232528 - Flags: review?(mconnor)
(Assignee)

Comment 2

12 years ago
Any reviews for this bug?
Assignee: nobody → romaxa
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

11 years ago
Comment on attachment 232528 [details] [diff] [review]
this will work most of the time

> nsTridentProfileMigrator::MigrateTridentProfile(PRUint32 aItems)
>+  nsTridentPreferences *pref;
>+#ifdef XP_WIN
>+  pref = MakeTridentPreferences();
you need:
 #else
    pref = nsnull
>+#endif
otherwise this accesses unintialized memory:
>   if (!pref)
>     return NS_ERROR_OUT_OF_MEMORY;
Attachment #232528 - Flags: review?(mconnor) → review-
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.