347733 - msie tridentprofile importer doesn't build on linux

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[Oleg Romashin (:romaxa)]

Yes, we know this is not quite sensible. but the code at least *thinks* about doing this and so, it should either think *harder* or less hard.

romaxa@romaxa-sr:/home/work/xulrunner/maemo-browser/build-tree/mozilla/debug-i686-pc-linux-gnu/extensions/tridentprofile$ make -s
nsTridentProfileMigrator.o: In function `nsTridentProfileMigrator::MigrateTridentProfile(unsigned int)':
/home/work/xulrunner/maemo-browser/build-tree/mozilla-cvs-20060803.0/extensions/tridentprofile/src/nsTridentProfileMigrator.cpp:69: undefined reference to `MakeTridentPreferences()'
collect2: ld returned 1 exit status
make[2]: *** [libtridentprofile.so] Error 1
make[1]: *** [libs] Error 2
make: *** [all] Error 2
romaxa@romaxa-sr:/home/work/xulrunner/maemo-browser/build-tree/mozilla/debug-i686-pc-linux-gnu/extensions/tridentprofile$ ls src/
Makefile  nsModule.o  nsTridentProfileMigrator.o

This is of course because the makefile looks like this:

ifeq ($(MOZ_WIDGET_TOOLKIT),windows)
CPPSRCS += nsTridentPreferencesWin.cpp
endif

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: this will work most of the time

Comment 2

[Oleg Romashin (:romaxa)]

Any reviews for this bug?

Comment 3

[timeless]

Comment on attachment 232528 [details] [diff] [review]
this will work most of the time

> nsTridentProfileMigrator::MigrateTridentProfile(PRUint32 aItems)
>+  nsTridentPreferences *pref;
>+#ifdef XP_WIN
>+  pref = MakeTridentPreferences();
you need:
 #else
    pref = nsnull
>+#endif
otherwise this accesses unintialized memory:
>   if (!pref)
>     return NS_ERROR_OUT_OF_MEMORY;

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.