347777 - Intel Mac should be detected as Hardware: PC rather than Hardware: Mac

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Asa Dotzler [:asa]]

Assuming that we've decided that Platform/Hardware really means "CPU Architecture" or similar, the Intel Macs should be detected as PC:Macintosh rather than Macintosh:Macintosh. 

Alternately, we could just convert the existing label to Mac-PPC and add a new item for Intel-Mac, but we'd still have to update the detection logic to do the right thing. 

This is getting increasingly more important for bmo as more and more bugs are turning out to be PPC or Intel Mac specific.

Comment 1

[Dave Miller [:justdave]]

What UserAgent does Firefox on a MacIntel send?

Comment 2

[Asa Dotzler [:asa]]

I get this from About:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b1) Gecko/20060807 BonEcho/2.0b1

Comment 3

[timeless]

this has been on my list for a whlie, but i didn't have a useragent, and boy does theirs *suck*. ok.

Comment 4

[timeless]

before i post a patch, could someone get me useragents for omniweb, opera, safari, safari-ppc(rosetta), msie(rosetta), camino

it should be sufficient to load:
javascript:navigator.userAgent in each of them.

Comment 5

[Samuel Sidler (old account; do not CC)]

All on Intel:
Opera/9.00 (Macintosh; Intel Mac OS X; U; en)
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1a3) Gecko/20060626 Camino/1.0+

Safari and OmniWeb don't support me just going to javascript:navigator.userAgent. How else would you like me to get the UA? Also, I don't have MacIE on this machine to see if it even runs well under Rosetta.

Comment 6

[Samuel Sidler (old account; do not CC)]

Safari (Intel and under Rosetta):
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en) AppleWebKit/418.8 (KHTML, like Gecko) Safari/419.3
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/418.8 (KHTML, like Gecko) Safari/419.3

OmniWeb (Intel, not under Rosetta):
Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US) AppleWebKit/420+ (KHTML, like Gecko, Safari/420) OmniWeb/v601

Still don't have MacIE. But I'd guess it'll say "PPC Mac OS X"...

Comment 7

[timeless]

Attachment: support intel

well research so far shows no harmful crossover. (ignoring omniweb, which i think i noticed when i researched this a while ago.)

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 232607 [details] [diff] [review]
support intel

>+            /\(.*Intel.*\)/ && do (@platform = "PC"; last;};

You have a paren here that needs to be a brace.

Comment 9

[timeless]

Attachment: support intel

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 232609 [details] [diff] [review]
support intel

Looks good.  This is clean on 2.20 and you have permission to commit on both 2.20 and 2.22 as well as trunk.  It's live on b.m.o already

Comment 11

[Frédéric Buclin]

As usual, timeless forgot to close this bug and report new file versions. :)

tip:

mozilla/webtools/bugzilla/enter_bug.cgi 1.144

2.22:

mozilla/webtools/bugzilla/enter_bug.cgi 1.126.2.1

2.20:

mozilla/webtools/bugzilla/enter_bug.cgi 1.114.4.4

Comment 12

[Josh Aas]

This is incorrect. Mac OS X does not run on generic PC hardware, and classifying it that way is confusing. Please reverse this.

Comment 13

[Asa Dotzler [:asa]]

The platform field should be renamed to CPU and the PC item should be renamed X86. Absent that, PC/Mac, Mac/Mac, and All/Mac is the only consistently queryable way to distinguish between bugs that impact the different Mac platforms.