347797 - [Mac] Tabs aligned to the left when they should be centered

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Mark Mentovai]

Spun off from bug 347533: native-theme tabs should be centered to match the native look and feel on the Mac.  They are now aligned to the left.  This is a regression from 1.5.  Screenshot at attachment 232335 [details] (that screenshot from bug 347533 also shows bug 347533, a vertical gap between the tabs and the horizontal bar.)

Comment 1

[Mark Mentovai]

Testcase: Tools:Page Info and Firefox:Preferences:Advanced.  The tabs in Firefox:Preferences:Advanced:Encryption:View Certificates are properly centered.

Comment 2

[Uri Bernstein]

FWIW, the regression (on trunk) was between 2006-04-13 and 2006-04-14.
I can't find an obvious candidate for what broke this.

Comment 3

[Mark Mentovai]

Thanks, Uri.  Also, note that the background in the Page Info window is white, when it should be a reasonable striped gray.  That regression occurred at the same time that the tabs shifted.

Regressed between 041304 and 041405 (trunk) and 041313 and 041403 (1.8):

http://bonsai.mozilla.org/cvsquery.cgi?branch=HEAD&branchtype=match&date=explicit&mindate=2006-04-13+01%3A00&maxdate=2006-04-14+06%3A00
http://bonsai.mozilla.org/cvsquery.cgi?branch=MOZILLA_1_8_BRANCH&branchtype=match&date=explicit&mindate=2006-04-13+10%3A00&maxdate=2006-04-14+04%3A00

Looks to me like bug 333863.

(...checking...)

Yup, that's it.  This line looks suspicious:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/macBrowserOverlay.xul&rev=1.9&mark=54#43

Mano, did you intend to reference a stylesheet there, or should we just remove that line?

Comment 4

[Asaf Romano (gone)]

Taking.

Comment 5

[Asaf Romano (gone)]

Attachment: Don't load browser.css

This _may_ regress places on trunk. If it turns out that's the case, I'll address it in a separate bug.

Comment 6

[Asaf Romano (gone)]

Checking in browser/base/content/macBrowserOverlay.xul;
/cvsroot/mozilla/browser/base/content/macBrowserOverlay.xul,v  <--  macBrowserOverlay.xul
new revision: 1.10; previous revision: 1.9
done

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 233212 [details] [diff] [review]
Don't load browser.css

a=drivers for MOZILLA_1_8_BRANCH

Comment 8

[Asaf Romano (gone)]

1.8 branch: Checking in browser/base/content/macBrowserOverlay.xul;
/cvsroot/mozilla/browser/base/content/macBrowserOverlay.xul,v  <--  macBrowserOverlay.xul
new revision: 1.7.8.3; previous revision: 1.7.8.2
done