Change some spellchecker assertions to just return failure

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: brettw, Assigned: brettw)

Tracking

({fixed1.8.1})

1.8 Branch
fixed1.8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
 
(Assignee)

Comment 1

12 years ago
Created attachment 232641 [details] [diff] [review]
Patch for the common cases
Attachment #232641 - Flags: review?(bryner)
here are the assertions I'm seeing after the fix for bug #347561:

WARNING: NS_ENSURE_TRUE(editor) failed, file
c:/builds/bonecho/mozilla/extension
s/spellcheck/src/mozInlineSpellChecker.cpp, line 1125

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
c:/builds/bonecho/mozilla
/extensions/spellcheck/src/mozInlineSpellWordUtil.cpp, line 91

I'll get some stacks for brett.
Attachment #232641 - Flags: review?(bryner) → review+
(Assignee)

Comment 3

12 years ago
Comment on attachment 232641 [details] [diff] [review]
Patch for the common cases

Requesting approval for this trivial change to assertions.
Attachment #232641 - Flags: approval1.8.1?
(Assignee)

Comment 4

12 years ago
Fixed on trunk, leaving open for branch.
(Assignee)

Comment 5

12 years ago
This patch also should improve performance a bit, since it saves a QueryReferent for every word checked.
(Assignee)

Updated

12 years ago
Blocks: 338999
Comment on attachment 232641 [details] [diff] [review]
Patch for the common cases

a=drivers, please land on the branch.
Attachment #232641 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 7

12 years ago
Fixed on branch.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
> I'll get some stacks for brett.

brett, I've updated and rebuilt the branch on windows xp, and with your changes and I no longer assert.

thanks for fixing this.

You need to log in before you can comment on or make changes to this bug.