347819 - Change some spellchecker assertions to just return failure

Status: RESOLVED FIXED

(Core :: Spelling checker, defect)

Description

[Brett Wilson]

Comment 1

[Brett Wilson]

Attachment: Patch for the common cases

Comment 2

[(not reading, please use [e-mail] instead)]

here are the assertions I'm seeing after the fix for bug #347561:

WARNING: NS_ENSURE_TRUE(editor) failed, file
c:/builds/bonecho/mozilla/extension
s/spellcheck/src/mozInlineSpellChecker.cpp, line 1125

WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed, file
c:/builds/bonecho/mozilla
/extensions/spellcheck/src/mozInlineSpellWordUtil.cpp, line 91

I'll get some stacks for brett.

Comment 3

[Brett Wilson]

Comment on attachment 232641 [details] [diff] [review]
Patch for the common cases

Requesting approval for this trivial change to assertions.

Comment 4

[Brett Wilson]

Fixed on trunk, leaving open for branch.

Comment 5

[Brett Wilson]

This patch also should improve performance a bit, since it saves a QueryReferent for every word checked.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 232641 [details] [diff] [review]
Patch for the common cases

a=drivers, please land on the branch.

Comment 7

[Brett Wilson]

Fixed on branch.

Comment 8

[(not reading, please use [e-mail] instead)]

> I'll get some stacks for brett.

brett, I've updated and rebuilt the branch on windows xp, and with your changes and I no longer assert.

thanks for fixing this.