347826 - nsXBLContentSink::ReportError can die

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Alex Vincent [:WeirdAl]]

Per sr feedback from bz, ReportError in nsXBLContentSink I noticed isn't doing anything really useful.  It overrides and calls upon nsXMLContentSink.

Marking as dependent on bug 342164.  This bug is being filed as part of the sr review requirements for that bug.

Comment 1

[Alex Vincent [:WeirdAl]]

Attachment: patch, v1

bz: I added debug logging of XML well-formedness errors as a part of this patch.  It was in nsXBLContentSink::ReportError, so I just copied the code over to nsXMLContentSink::ReportError.

It may not be necessary, but it might be useful to developers who prefer to look at the debug console.  Since that's current behavior for XBL, and harmless for non-debug XML, I figured this was okay.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 235516 [details] [diff] [review]
patch, v1

> It was in nsXBLContentSink::ReportError

Because it was the only way to debug bugs in XBL that prevent the error console from appearing, say.  I'd rather not add even more clutter to our debug build consoles...

That said, I'm not sure what this patch is trying to do.  Originally, I thought this bug was about removing redundant logging, but you removed it in bug 342164.  I'd prefer to keep this ReportError method, so that someone might actually fix the XXX comment you helpfully removed in this patch.

So it seems to me that at this point this bug should be wontfix or something.

Comment 3

[Alex Vincent [:WeirdAl]]

I was reading the functionality as being essentially useless code.  That's why I filed this bug; after my changes, there didn't seem to be much point.  I honestly don't understand how my intent could not have been clear.

I'm fine with WONTFIX'ing this bug.

Comment 4

[Alex Vincent [:WeirdAl]]

per last comment, WONTFIX