Closed Bug 34783 Opened 24 years ago Closed 24 years ago

Using popup menus blows out stack

Categories

(Core :: XUL, defect, P1)

Product:
Core
Component:
XUL
Platform:
x86
Windows 98
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: mozilla, Assigned: hyatt)

References

Details

(Keywords: regression, Whiteboard: [PDT+]) 

I just pulled a fresh M15 tip on Win98 (as of 1:30 AM on April 6).  I'm seeing 
crashes when using various popup menus.  (I'm unable to get a stack trace on 
Win98, sorry.)

Run Mozilla, open the Search sidebar panel, and choose a search category from 
the popup menu.  Mozilla will crash, apparently its blowing out the stack.

As another example, open the Bookmarks sidebar panel, select a bookmark (a real 
bookmark, not a bookmark folder or a separator), bring up a context menu and 
choose "Properties". Click on the "Schedule" tab at the top of the Properties 
window, and then choose any item from any of the popup menus.  Again, Mozilla 
will crash after blowing out the stack.

I'm guessing that there are lots of other places where using popup menus will 
crash.

This is a major regression.

Peter, I'm guessing that someone on your team gets first crack at this.
Severity: normal → major
Keywords: dogfood, regression
Priority: P3 → P2
Whiteboard: PDT
assigning to pinkerton as p1 for m15, bumping severity to critical (crash).  cc 
hyatt.

Robert, why did you add 'PDT' to the status whiteboard?
Assignee: trudelle → pinkerton
Severity: major → critical
Priority: P2 → P1
Target Milestone: --- → M15
Bad habit.  :^)
->claudius.
QA Contact: sairuh → claudius
is this a regression because someone started using menulist instead of selects? 
is this win98 only? I don't see any of these problems on NT. Can't tell on mac 
because the sidebar has been broken for weeks in Mozilla.
Status: NEW → ASSIGNED
Pink, pulls all of evaughan's fixes from yesterday, and the sidebar will work on 
Mac. (Does for me, anyway.)

I don't have NT here at home, sorry.
works for me on mac and NT. not sure what you want me to do about this.

Try Win98.  :^)
okeee, and where do i get one of those machines?

Hyatt uses Win98 a lot (unless he upgraded all of his machines to Win2K).

Or, feel free to drop by my place for some debugging.

Hey, you asked.  :^)

oh saari, this is a focus bug. i'll help show you where it is.
Assignee: pinkerton → saari
Status: ASSIGNED → NEW
Whiteboard: PDT
here's more info:

- it only happens when using popups the "windows" way (multiple clicks to select 
the item). click and drag with the popup works fine

- we get the mousedown selecting the menu item and it goes into postHandleEvent. 
it then tries to give the popup focus and goes into an infinite loop at the 
widget level.

- doesn't crash mac/linux/nt. only 9x. saari said rods changed some win32 widget 
focus handling recently. maybe this is an interaction.
Assignee: saari → hyatt
Putting on PDT radar.  Win 98 usability is blocked without this.
Whiteboard: [PDT+]
*** Bug 35327 has been marked as a duplicate of this bug. ***
*** Bug 35327 has been marked as a duplicate of this bug. ***
*** Bug 35327 has been marked as a duplicate of this bug. ***
Any status on this? This is one of two m15 bugs left.

See all of my checkin that had the checkin comment "Cuddling mailnews and giving 
it some sweet sweet love."

This bug has actually been fixed for a day or two.  JUst forgot to mark it 
fixed.  Fix is on the tip, not on the branch.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
I just *knew* you were going to leave the bug number out of your amusing, yet
non-informative, checkin comments.

How scary are these changes, in your opinion? And do i need them *all*?
leaf checked hyatt's love into the M15 branch ... I tried to reproduce the 
crash on a win98 machine with todays comm. build and could not. Seems good
to me ... claudius?
works fine for me with the 2000041809 build on Win98...marking VERIFIED
Status: RESOLVED → VERIFIED
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: claudius → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.