Closed Bug 347887 Opened 19 years ago Closed 18 years ago

Memory leak in icimage.c

Categories

(Core Graveyard :: Image: Painting, defect)

x86
SunOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: alfred.peng, Assigned: pavlov)

Details

(Keywords: memory-leak)

Attachments

(1 file)

There are some memory leak for image->pSourcePict when _pixman_init_gradient call fails.
Attached patch Patch v1Splinter Review
Attachment #232752 - Flags: review?(pavlov)
please use tabs instead of spaces in that file like every other line. also, this should be filed with upstream cairo and not here.
Thanks for the report. This is fixed in upstream cairo now: http://gitweb.freedesktop.org/?p=cairo;a=commit;h=db06681b487873788b51a6766894fc619eb8d8f2 -Carl PS. And yes, cairo bugs in cairo's bugzilla would be helpful.
Pavlov, do we still need this patch for mozilla after Carl checked it into cairo library? If not, I'll close the bug.
The patch is already in the trunk code after the sync of cairo. =>Close it.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #232752 - Flags: review?(pavlov)
Keywords: mlk
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: