Closed
Bug 347902
Opened 18 years ago
Closed 18 years ago
Duplicate accesskey "o" in Message menu
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird2.0
People
(Reporter: timwi, Assigned: mkmelin)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
1.62 KB,
patch
|
mscott
:
review+
mscott
:
superreview+
mscott
:
approval-thunderbird2+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6 The "Message" menu has two commands both of which have the "o" accesskey: - F_o_rward As => - _O_pen message (Ctrl+O) Please can you make sure that this does not happen again? When you introduce a new menu item or change an accesskey, it's really not that hard to check if it's already taken. :/ Reproducible: Always
Assignee | ||
Comment 1•18 years ago
|
||
->new
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 2000 → All
Hardware: PC → All
Assignee | ||
Comment 2•18 years ago
|
||
This changes the accesskey for "Forward as" from o -> w. I also found some unused strings, lxr for the strings this patch removes: http://lxr.mozilla.org/seamonkey/search?string=unreadCountText.label http://lxr.mozilla.org/seamonkey/search?string=totalCountText.label http://lxr.mozilla.org/seamonkey/search?string=loadFirstDraft.label http://lxr.mozilla.org/seamonkey/search?string=editDraftCmd.label http://lxr.mozilla.org/seamonkey/search?string=editDraftCmd.accesskey
Assignee: mscott → mkmelin+mozilla
Status: NEW → ASSIGNED
Attachment #233354 -
Flags: superreview?(mscott)
Attachment #233354 -
Flags: review?(mscott)
Comment 3•18 years ago
|
||
Comment on attachment 233354 [details] [diff] [review] proposed fix (tb only) I can't believe we've never noticed this before!
Attachment #233354 -
Flags: superreview?(mscott)
Attachment #233354 -
Flags: superreview+
Attachment #233354 -
Flags: review?(mscott)
Attachment #233354 -
Flags: review+
Attachment #233354 -
Flags: approval-thunderbird2+
Updated•18 years ago
|
Whiteboard: [checkin needed]
Comment 4•18 years ago
|
||
mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd 1.17.2.25 mozilla/mail/locales/en-US/chrome/messenger/messenger.dtd 1.44
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Thunderbird2.0
Version: unspecified → 2.0
You need to log in
before you can comment on or make changes to this bug.
Description
•