Closed
Bug 347913
Opened 18 years ago
Closed 18 years ago
No longer firing EVENT_ALERT for browsermessage bar
Categories
(Firefox :: Disability Access, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: deangelo, Assigned: aaronlev)
References
()
Details
(Keywords: access, fixed1.8.1, regression, Whiteboard: Very low risk, simple patch. Critical regression fix without which screen reader users don't know about notifications.)
Attachments
(1 file)
1.07 KB,
patch
|
pilgrim
:
review+
mconnor
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
Test environment: Windows XP, Firefox 2 (Bon Echo) build 20060807, Inspect32 (Inspect Objects) Optional: screen reader (JAWS 7.1 or Window-Eyes 5.5N (latest beta)) Description: This user is not hearing the browser message alert bar with Window-Eyes when he tries to install an extension from here: http://dragtotab.mozdev.org/popupsound/. This is a regression because it worked fine at older nightly build versions. Steps to Recreate: 1. Start up WE 5.5N and FF2. 2. Bring up the URL: http://dragtotab.mozdev.org/popupsound/ 3. Click on "Install it" 4. You will notice that a message bar will appear stating "Bon Echo prevented this site (dragtotab.mozdev.org) from asking you to install software on your computer. BUT Window Eyes does not speak any of the dialog. Expected results: The screen reader JAWS or WE 5.5N in this case should read the contents of messagebanner. NOTE: This is a regression, seems to work with the old format using a pop dialog in Bon Echo nigthly build 20070706.
Reporter | ||
Updated•18 years ago
|
Flags: blocking-firefox2?
Assignee | ||
Comment 1•18 years ago
|
||
Yikes, this has to do with the notification widget. There's a notifcation and a notificationbox element. We're creating the accessible for the notification but firing the AlertActive for the notificationbox. The generated accessible and event need to be for the same DOM element. Another problem is that the notifcation box seems to surround the entire content. I need a node which has just the notification in it.
Severity: normal → critical
Assignee | ||
Comment 2•18 years ago
|
||
It turns out we're creating the correct accessible but we need to fire the AlertActive for that accessible's DOM node. The right DOM node has the notifcation binding, not the notificationbox binding.
Assignee | ||
Comment 3•18 years ago
|
||
Assignee: nobody → aaronleventhal
Status: NEW → ASSIGNED
Attachment #232789 -
Flags: review?(pilgrim)
Updated•18 years ago
|
Attachment #232789 -
Flags: review?(pilgrim) → review+
Assignee | ||
Updated•18 years ago
|
Attachment #232789 -
Flags: approval1.8.1?
Updated•18 years ago
|
Attachment #232789 -
Flags: review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: Very low risk, simple patch. Critical regression fix without which screen reader users don't know about notifications.
Assignee | ||
Updated•18 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 4•18 years ago
|
||
Comment on attachment 232789 [details] [diff] [review] 1) Fire AlertActive for notification not for notificationbox, 2) Wait to fire it until the notification is visible a=drivers, please land on the branch
Attachment #232789 -
Flags: approval1.8.1? → approval1.8.1+
Assignee | ||
Updated•18 years ago
|
Keywords: fixed1.8.1
Updated•18 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Updated•18 years ago
|
Summary: No longer firing EVENT_ALERT for browsermessage bar" → No longer firing EVENT_ALERT for browsermessage bar
You need to log in
before you can comment on or make changes to this bug.
Description
•