Closed Bug 347926 Opened 18 years ago Closed 18 years ago

remove arc4.js and friends from source tree

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: tony, Assigned: tony)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file, 1 obsolete file)

v2: return immediately after no host
15.59 KB, patch
darin.moz
: superreview+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review 
Once bug 337733 lands, we can remove the javascript implementation of rc4 from the anti-phishing code and use the XPCOM interface instead.
Flags: blocking-firefox2?
Attached patch v1: use nsIStreamCipher (obsolete) — — Splinter Review 
This works given the current interface.  Posting it before bug 337733 lands on the off chance I get hit by a trunk or something.
Flags: blocking-firefox2? → blocking-firefox2+
Attachment #232829 - Attachment description: v1: use pending nsistreamcipher → v1: use nsIStreamCipher
Attachment #232829 - Flags: review?(provos)
Comment on attachment 232829 [details] [diff] [review]
v1: use nsIStreamCipher

the only thing that is a bit weird is catching the exception on asciihost.  there does not seem to be any point to continue with any empty host.  fine otherwise.
Attachment #232829 - Flags: review?(provos) → review+
Same as v1 except we return immediately after catching.

We still want to catch so the function returns cleanly and we don't throw exceptions unnecessarily.
Attachment #232829 - Attachment is obsolete: true
Attachment #233404 - Flags: superreview?(darin)
Attachment #233404 - Flags: superreview?(darin) → superreview+
on trunk
Attachment #233404 - Flags: approval1.8.1?
Comment on attachment 233404 [details] [diff] [review]
v2: return immediately after no host

a=beltzner on behalf of drivers for the mozilla_1_8_branch.
Attachment #233404 - Flags: approval1.8.1? → approval1.8.1+
on branch
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
*** Bug 347918 has been marked as a duplicate of this bug. ***
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: