347931 - fr Search Feature Tracking

Status: VERIFIED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[chris hofmann]

Fill this bug with:
* "Search Suggests" enable/disable for locales where available or not
* Default Search partner order and full search partner list.
** should include any additional search plugins that should ship by default in the locale...
* Any special search codes sent to the engines.
* primary/secondary search selection behavior
* and anything else about how the search box is/should be working in this locale

Comment 1

[chris hofmann]

This is an expansion of searcbh requirements and test tool info for the fr build from the following sources

http://wiki.mozilla.org/Firefox2/L10n_Requirements#Search_Plugins
http://people.mozilla.com/~axel/nightly-1.8/search-engines.html



In the search box in the fr build should have:

Google

Google should be listed first.
Google contacts and approvals for using their service are in place.

The fr build should use the standard google search plugin that will result in the following behavior:

The "Search Suggest" feature should be enabled and typing in the search box should generate queries of the form

Google should be listed first.
Google contacts and approvals for using their service are in place.

Search suggest feature should be enabled and typing in the search box should generate queries of the form
http://suggestqueries.google.com/complete/search?output=firefox&client=firefox&qu=foo

A Google search should send the following query:
http://www.google.com/search?q={searchTerms}&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official

Google will redirect the search from a french firefox build to a google french server.

Yahoo

Yahoo should be listed second in the search dropdown list.
Yahoo contacts and approvals for using their service are in place.
French search suggest is not enabled for Yahoo searches at this time.
A Yahoo search for "foo" should send queries of the form
http://fr.search.yahoo.com/search?p=foo&ei=UTF-8&fr=moz2&rls=org.mozilla:fr:official

Other search providers in the french builds appear in no particular order

Amazon

Amazon contacts are in place and we have approval to use their service.
A search foo should generate queries of the form
http://www.amazon.fr/exec/obidos/external-search/?field-keywords=foo&mode=blended&tag=mozilla-20&sourceid=Mozilla-search
and amazon will redirect

ebay

eBay contacts are in place and we have approval to use their service.
A search "test" should generate queries of the form
http://search.ebay.fr/test_W0QQfrppZ50QQfsopZ1QQmaxrecordsreturnedZ300


Wikipedia

Mic is working on wikipedia contacts and ToS review
Search for "test" should generate the following query directed a french site.
http://fr.wikipedia.org/w/wiki.phtml?search=test&sourceid=Mozilla-search

mediadico

Can someone also forward a contact for the site to Mic if they have one?
I spotted these terms of service for Mediadico.
Does anyone know if these have been reviewed, and we confirm we are in compliance?
http://www.mediadico.com/utilisation-dictionnaire.asp,
http://www.mediadico.com/dictionnaire-familial.asp,
http://www.mediadico.com/dictionnaire-entreprise.asp,
any help on this would be appreciated.

Queries appear to send the form
http://www.dictionnaire-mediadico.com/dictionnaires.asp?Action=definition&alea=2005&mot=test


does this all sound correct for search in the fr build?

Comment 2

[Benoit]

(In reply to comment #1)
> A Google search should send the following query:
> http://www.google.com/search?q={searchTerms}&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:en-US:official

Don't you mean http://www.google.com/search?q={searchTerms}&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:fr:official ?

> mediadico
> 
> Can someone also forward a contact for the site to Mic if they have one?

We had two contacts, an administrative one (which allowed us to use their service) and a technical one (which provided us with the search plugin and the icon). I'll try to find these ones back. Tristan Nitot may have at least one of them too. Now the question remains: how does one contact Mic? :)

> I spotted these terms of service for Mediadico.
> Does anyone know if these have been reviewed, and we confirm we are in
> compliance?
> http://www.mediadico.com/utilisation-dictionnaire.asp,
> http://www.mediadico.com/dictionnaire-familial.asp,
> http://www.mediadico.com/dictionnaire-entreprise.asp,
> any help on this would be appreciated.

AFAICT, only http://www.mediadico.com/dictionnaire-familial.asp is relevant here; it says that the service is free for personal use, either at home or at work. The entreprise version is a paid-for enhanced service (more sources) for intranets.

> Queries appear to send the form
> http://www.dictionnaire-mediadico.com/dictionnaires.asp?Action=definition&alea=2005&mot=test

That's correct. See bug #313464 comment #5 for an explanation on the "alea" thing.

Anyway, I see on their website that they recently introduced an Internet Explorer search bar. If you happen to contact them, you could suggest them to add an installable OpenSearch plugin (for users who don't already have it) and an explanation on how to install it in Firefox2.

Comment 3

[Axel Hecht [:Pike]]

(In reply to comment #1)
> does this all sound correct for search in the fr build?
> 

No, amazon and google keys are wrong.

Google should of course send :fr: and not :en-US:, and Amazon should use firefox-fr-21 instead of mozilla-20.

Comment 4

[Axel Hecht [:Pike]]

Adding Mic to CC, too.

Comment 5

[chris hofmann]

yes, sorry for the cut and paste typo on google
http://www.google.com/search?q={searchTerms}&ie=utf-8&oe=utf-8&client=firefox-a&rls=org.mozilla:fr:official

I checked the latest fr build I could find on ftp
Identifiant de compilation : Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1b1) Gecko/2006081606 BonEcho/2.0b1

And it looks like it is returning this when I do a search for foo..
http://www.google.com/search?q=foo&ie=utf-8&oe=utf-8&rls=org.mozilla:fr:unofficial&client=firefox-a

so 
1) it looks like there is no redirection to a fr google server, 
2) but we do get french results and content
3) any one know if a fix is in to replace "unofficial", or understand why I see that in the build from the 16th?  I think we are ok to flip offical on.

I'll also fix amazon to be  
http://www.amazon.fr/exec/obidos/external-search/?field-keywords=foo&mode=blended&tag=firefox-fr-21&sourceid=Mozilla-search

Comment 6

[Axel Hecht [:Pike]]

Could you check a b2 build?
Looking at the build log, l10n builds should have official branding on.

Thinking about it, I probably would expect that client=firefox-a would be sent last in en-US, too. That'd be good to check, too.

Comment 7

[chris hofmann]

stuff in ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla1.8-l10n is from the 16, where are we putting beta2 candidates?

Comment 8

[Cédric Corazza]

We are taking them in ftp://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox/latest-mozilla1.8-l10n at the bottom of the page

Comment 9

[chris hofmann]

ok,  I installed the latest fr .xpi.  I checked the searchplugin/google.xml file.  it says rls value {moz:offical}...  but I still see rls=org.mozilla:fr:unofficial&client=firefox-a when I to a search from the search box...  anyone else with a french build see this?

Comment 10

[Cédric Corazza]

I confirm this :
google.xml searchplugin indicates {moz:official} but the displayed address in the location bar indicates:
http://www.google.fr/search?q=foo&ie=utf-8&oe=utf-8&rls=org.mozilla:fr:unofficial&client=firefox-a

Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1b2) Gecko/20060823 BonEcho/2.0b2

Comment 11

[:Gavin Sharp [email: [e-mail]]]

The value of the {moz:official} parameter depends on --enable-official-branding. If official branding is enabled, it sends "official", otherwise it sends "unofficial".

Comment 12

[chris hofmann]

ok, thanks gavin.  looks like en-US build from yesterday is doing the same. filed bug 350090 to track when the right switches get flipped.

Comment 13

[Axel Hecht [:Pike]]

After looking a tad closer, this actually depends on the build flag in the original build and is independent of repackaging.
And official branding is not on on pacifica. We're going to see the same behaviour on all l10n builds.

Note, the google redirect behaviour is expected, you only get redirected to a local domain if your geo-location matches the language of the http accept lang header.

As fr actually uses the en-US google plugin, this just confirms that that plugin does the right (expected) thing in the french build.

Comment 14

[chris hofmann]

at the top of the test I'll add:

  check "about:buildconfig" to ensure offical branding has been enabled.

so the tester won't run in circles tracking down why unoffical might be set.

Maybe .mozconfig checks should be added to the script that generates 
http://people.mozilla.com/~axel/nightly-1.8/search-engines.html

would that make sense, since it looks like the plugin .xml file alone doesn't result in the right search code.

Comment 15

[chris hofmann]

Attachment: v1 fr search test doc.

this version should be ready to use.  if mods are required obsolete this version and submit a new one.

Comment 16

[Axel Hecht [:Pike]]

Stuff to be done:

remove suggest from Yahoo
change Amazon to tag=firefox-fr-21

Mic, if you have all the information to close down this bug from a BD point of view, a comment indicating that would be good. Otherwise a list of stuff pending.

Comment 17

[Cédric Corazza]

(In reply to comment #16)
> Stuff to be done:
> 
> remove suggest from Yahoo
> change Amazon to tag=firefox-fr-21

Done:
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/searchplugins&command=DIFF_FRAMESET&file=amazon-france.xml&rev1=1.1.2.1&rev2=1.1.2.2&root=/l10n
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/searchplugins&command=DIFF_FRAMESET&file=yahoo-france.xml&rev1=1.1.2.3&rev2=1.1.2.4&root=/l10n

Comment 18

[Cédric Corazza]

We had to change input encoding for MediaDico searchplugin from UTF-8 to ISO-8859-1. Accented letter were wrongly displayed on the mediadico site which displays pages in iso-8859-1:
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/searchplugins&command=DIFF_FRAMESET&file=MediaDICO-fr.xml&rev1=1.1.2.1&rev2=1.1.2.2&root=/l10n

Comment 19

[Mic Berman]

note to all: this has been reviewed for FF2 from BD and is good to go
thanks very much for your help
mic

Comment 20

[Axel Hecht [:Pike]]

Resolving FIXED.

We may land a technical change to the yahoo plugin, which won't change the behaviour in official releases, though, as part of bug 351817.

Comment 21

[Cédric Corazza]

Reopening this bug as suggested by Axel. See bug 350248 comment#14

Mic,
We were asked by an end-user if we could change the Wikipedia searchplugin icon
for a nicer one:
http://carey.geek.nz/code/wikipedia-searchplugin/wikipedia-64.png
Are we allowed to do that ?

Comment 22

[Mic Berman]

hi
yes sure (do you know the source of this image? for example is it official)
also, let me see if i can get an official one from wikipedia themselves
best
mic

Comment 23

[Mic Berman]

to clarify my last response (i think it may have been unclear)
Yes, BD is good to go with that image. 
I will send another image *IF* I receive one directly from Wikipedia.
i hope that's clearer. If so, please go ahead and close this bug
thanks
mic

Comment 24

[Cédric Corazza]

(In reply to comment #23)
> to clarify my last response (i think it may have been unclear)
> Yes, BD is good to go with that image. 
> I will send another image *IF* I receive one directly from Wikipedia.
> i hope that's clearer. If so, please go ahead and close this bug

Ok Mic, that's clearer now. I thought I had to wait for the answer. I will commit the change tomorrow evening (Paris time) and not close the bug. AFAIK, this icon is pulled from the wikipedia stuff, but I have to proof to provide.

Comment 25

[chris hofmann]

nominating so it gets on the blocker list for better tracking.  we shouldn't let fr fx2 go out the door with out a wikipedia branding icon..  looks like this is on track to land tomorrow..  thanks

Comment 26

[Cédric Corazza]

(In reply to comment #25)
> nominating so it gets on the blocker list for better tracking.  we shouldn't
> let fr fx2 go out the door with out a wikipedia branding icon..  looks like
> this is on track to land tomorrow..  thanks
> 
Checking in the new icon on branch and trunk:
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/searchplugins&command=DIFF_FRAMESET&file=wikipedia-fr.xml&rev1=1.1.2.1&rev2=1.1.2.2&root=/l10n
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=l10n/fr/browser/searchplugins&command=DIFF_FRAMESET&file=wikipedia-fr.xml&rev1=1.2&rev2=1.3&root=/l10n

Well : this is not a real blocker. I mean: we like to please our users, esp. when we agree with them ;-) . But, if Mic doesn't have any answer from Wikipedia by Sunday night, no problem to revert that. We don't want to block the fr release for such a cosmetic thing. Just let us know before the lockdown.
Regards

Comment 27

[chris hofmann]

general terms of service on a lot of sites require the right kind of icon branding when the service is used.  thats the risk of doing no branding, or incorrect branding when we link to wikipedia.  thats mostly what I'm worrried about on this one.  thanks for staying right on top of this one mic and cedric...

Comment 28

[Axel Hecht [:Pike]]

Not blocking, Wikipedia's OpenSearch plugin that's linked from the wikipedia site itself is the 'W' icon that's used for all the other wikipedia plugins.
The globe that fr wants is another brand of wikipedia, which is used for wikipedia pins, for example. We're merely changing from one to the other, thus, not blocking.

Closing this bug.

Mic, if you get a countering statement, please reopen.

Comment 29

[Axel Hecht [:Pike]]

Attachment: list.txt, rev 1.1.2.5

Comment 30

[Tracy Walker [:tracy]]

verified with fr 2.0rc1 builds

Comment 31

[Mic Berman]

comment #28
acknowleding and will do if i get anything countering (i do not expect we will get anything countering)
thanks
mic