347936 - Allow browser search order to be set for positions beyond 1 and 2

Status: RESOLVED WONTFIX

(Firefox :: Search, defect, P4)

Description

[Mike Schroepfer]

It is my understanding that when locales and extensions set search engines order they can currently only set the first two positions - i.e.:

from: 

http://lxr.mozilla.org/l10n-mozilla1.8/source/ja/browser/chrome/browser-region/region.properties

 7 browser.search.order.1                  = Yahoo! JAPAN
  8 browser.search.order.2                  = Google
  9 browser.search.order.3                  = \u697d\u5929\u5e02\u5834
 10 browser.search.order.4                  = goo \u30a6\u30a7\u30d6
 11 browser.search.order.5                  = Yahoo!\u30b7\u30e7\u30c3\u30d4\u30f3\u30b0
 12 browser.search.order.6                  = Yahoo!\u30aa\u30fc\u30af\u30b7\u30e7\u30f3
 13 browser.search.order.7                  = Amazon.co.jp
 14 browser.search.order.8                  = Creative Commons
 1


Requires modification of:

http://lxr.mozilla.org/l10n-mozilla1.8/source/ja/browser/firefox-l10n.js

as such to register the preferences:

pref("browser.search.order.3","chrome://browser-region/locale/region.properties");
pref("browser.search.order.4","chrome://browser-region/locale/region.properties");
pref("browser.search.order.5","chrome://browser-region/locale/region.properties");
pref("browser.search.order.6","chrome://browser-region/locale/region.properties");
pref("browser.search.order.7","chrome://browser-region/locale/region.properties");
pref("browser.search.order.8","chrome://browser-region/locale/region.properties");


It would be nice to have these prefs registered by default so that locals and distributions can set absolute order for all search plug-ins.   Apologies in advance if I have this wrong - just talking to Axel today it great to have search engine orders defined only in properties files.

Comment 1

[Axel Hecht [:Pike]]

We would like to get adding preference redirects in firefox-l10n.js out of the tree for Firefox 3, as that's brittle. Requesting blocking.

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

It is set for 3 positions now 

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser-region/region.properties

I'm not sure if this helps the original poster's issue.

Comment 3

[Axel Hecht [:Pike]]

Yeah, when we added Bing, we went to 3 by default. The original issue still stands, we can't define the order beyond that without patching the prefs. See http://mxr.mozilla.org/l10n-mozilla-aurora/source/ja/browser/firefox-l10n.js for a current example.

Comment 4

[Mark Banner (:standard8)]

Since everything moved into mozilla-central, we can set the order via list.json. These prefs aren't really used now except for distributions and I don't see us doing anything for those.