get rid of kTitleBarHeight constant in cocoa widgets

RESOLVED FIXED

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
PowerPC
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

2.92 KB, patch
mano
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

12 years ago
We should get rid of the kTitleBarHeight constant in cocoa widgets. We can do better than that.
(Assignee)

Comment 1

11 years ago
Created attachment 249218 [details] [diff] [review]
fix v1.0
Attachment #249218 - Flags: review?(mark)
Comment on attachment 249218 [details] [diff] [review]
fix v1.0

please assert on aWindow in titleBarHeightForWindow.

r=mano otherwise.
Attachment #249218 - Flags: review+
(Assignee)

Updated

11 years ago
Attachment #249218 - Flags: review?(mark) → superreview?(mikepinkerton)
Comment on attachment 249218 [details] [diff] [review]
fix v1.0

sr=pink
Attachment #249218 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 4

11 years ago
landed on trunk
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.