"about:" is translatable, but its direction is LTR

RESOLVED FIXED in Firefox 2 beta2

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: zwnj, Assigned: steffen.wilberg)

Tracking

(Blocks: 1 bug, {fixed1.8.1, l12y})

2.0 Branch
Firefox 2 beta2
fixed1.8.1, l12y
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

12 years ago
If the page is translatable, then it should be RTL for RTL locales too.

I'm going to attach the screenshot.
(Reporter)

Comment 1

12 years ago
Created attachment 232862 [details]
'about:' in Persian (RTL) locale
(Assignee)

Comment 2

12 years ago
Created attachment 232998 [details] [diff] [review]
<body dir="&about.page-direction;">

Makes the page direction localizable.
Mano, Axel?
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #232998 - Flags: review?(l10n)
We shoud just use locale.dir from global.dtd (unless you want to take care of the case where this page isn't translated).
(Assignee)

Updated

12 years ago
Attachment #232998 - Attachment is obsolete: true
Attachment #232998 - Flags: review?(l10n)
(Assignee)

Comment 4

12 years ago
Created attachment 233154 [details] [diff] [review]
<body dir="&locale.dir;">
Attachment #233154 - Flags: review?(bugs.mano)
(Assignee)

Updated

12 years ago
Attachment #233154 - Attachment is obsolete: true
Attachment #233154 - Flags: review?(bugs.mano)
(Assignee)

Comment 5

12 years ago
Created attachment 233155 [details] [diff] [review]
<body dir="&locale.dir;">
Attachment #233155 - Flags: review?(bugs.mano)
Comment on attachment 233155 [details] [diff] [review]
<body dir="&locale.dir;">

r=mano
Attachment #233155 - Flags: review?(bugs.mano) → review+
(Assignee)

Comment 7

12 years ago
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
Attachment #233155 - Flags: approval1.8.1?
Comment on attachment 233155 [details] [diff] [review]
<body dir="&locale.dir;">

a=drivers, please land on MOZILLA_1_8_BRANCH
Attachment #233155 - Flags: approval1.8.1? → approval1.8.1+

Comment 9

12 years ago
Yep, looks good to me.
(Assignee)

Comment 10

12 years ago
Fixed on branch.
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 beta2
You need to log in before you can comment on or make changes to this bug.