Closed Bug 347977 Opened 18 years ago Closed 18 years ago

"about:" is translatable, but its direction is LTR

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: zwnj, Assigned: steffen.wilberg)

References

(Blocks 1 open bug)

Details

(Keywords: fixed1.8.1, l12y)

Attachments

(2 files, 2 obsolete files)

'about:' in Persian (RTL) locale
69.70 KB, image/png
Details
<body dir="&locale.dir;">
1.57 KB, patch
asaf
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
If the page is translatable, then it should be RTL for RTL locales too. I'm going to attach the screenshot.
Makes the page direction localizable. Mano, Axel?
Assignee: nobody → steffen.wilberg
Status: NEW → ASSIGNED
Attachment #232998 - Flags: review?(l10n)
We shoud just use locale.dir from global.dtd (unless you want to take care of the case where this page isn't translated).
Attachment #232998 - Attachment is obsolete: true
Attachment #232998 - Flags: review?(l10n)
Attached patch <body dir="&locale.dir;"> (obsolete) — — Splinter Review
Attachment #233154 - Flags: review?(bugs.mano)
Attachment #233154 - Attachment is obsolete: true
Attachment #233154 - Flags: review?(bugs.mano)
Attachment #233155 - Flags: review?(bugs.mano)
Comment on attachment 233155 [details] [diff] [review] <body dir="&locale.dir;"> r=mano
Attachment #233155 - Flags: review?(bugs.mano) → review+
Fixed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #233155 - Flags: approval1.8.1?
Comment on attachment 233155 [details] [diff] [review] <body dir="&locale.dir;"> a=drivers, please land on MOZILLA_1_8_BRANCH
Attachment #233155 - Flags: approval1.8.1? → approval1.8.1+
Yep, looks good to me.
Fixed on branch.
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 beta2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: