348113 - ro Search Feature Tracking for Firefox 2

Status: VERIFIED FIXED

(Mozilla Localizations :: ro / Romanian, defect)

Description

[chris hofmann]

tracking bug to make sure we get things on the list below working correctly for
each locale:

Full Default Search partner list/order.
primary/secondary search selection behavior
Search codes.
Search Suggests enable/disable for locales where available or not

Comment 1

[chris hofmann]

May need to look at order.   Should google be listed last?

Yahoo	
Amazon.com	
Answers.com	
Creative Commons	
eBay	
Google

http://lxr.mozilla.org/l10n-mozilla1.8/source/ro/browser/chrome/browser-region/region.properties
shows  
13 browser.search.order.1=Google.ro
14 browser.search.order.2=Yahoo

It sounds like Google.ro needs to be changed to Google

Comment 2

[Axel Hecht [:Pike]]

As Chris says, order needs to be fixed.
browser.search.defaultenginename=Google, too.

Iulian, as you only reference plugins that are pulled from en-US, you can cvs remove your copies in ro/browser/searchplugins, you only need list.txt.

That is, if you're fine with just shipping the en-US plugins for 2.0, too. If so, we should get the order fixed and resolve this bug.

Comment 3

[Axel Hecht [:Pike]]

Cutting the dependency to the 2.0 search tracking bug 347914, we'll keep track of this due to bug 352125, which we pick up once we have ro in a state that it can be released. That's likely going to wait for an upcoming minor release.

Comment 4

[Axel Hecht [:Pike]]

Alexandru, could you attach a romanian wikipedia search engine file here for review? There isn't a whole lot more to do apart of that, AFAICT. You could, if you want remove answers in return, not sure how useful that is to romanian users, in particular when wikipedia is there.

Comment 5

[Alexandru Szasz]

Attachment: Wikipedia in romanian search plugin

Here it is. I supposed the xml format is required. I agree to removing answers.com and placing wikipedia instead.

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 257666 [details]
Wikipedia in romanian search plugin

Technically, this looks good.

Can you attach a patch for list.txt, too, please?

Comment 7

[Alexandru Szasz]

Attachment: replaced answers.com with wikipedia in romanian

Comment 8

[Axel Hecht [:Pike]]

Mic, can you sign off on the change from answers to ro.wikipedia.org for Romanian?

Alexandru, we still need to fix comment 1, too. That'd be simply replacing Google.ro with Google in region.properties.

Comment 9

[Mic Berman]

Hi Alexandru,
Consider this a sign off to replacing Answers with Ro.Wikipedia.Org.
Would you mind providing the new search engine plug-in order, is it:
Google
Yahoo   
Amazon.com      
ro.Wikipedia.org     
Creative Commons        
eBay    

thanks
mic

Comment 10

[Axel Hecht [:Pike]]

Actually, order will be taken care of as soon as region.properties is fixed, anything but Google (first and default) and Yahoo (second) should be alphabetical. For Alexandru, the order inside list.txt doesn't matter.

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 257670 [details] [diff] [review]
replaced answers.com with wikipedia in romanian

r=me.

Comment 12

[Mic Berman]

oops on my part, that is true and our normal approach
my apologies, my only excuse was not having had my morning coffee yet ;-)
to be clear the change to ro.wikipedia.org from answers.com is still approved and Axel is exactly right about the order

Comment 13

[Alexandru Szasz]

Ok, everything related to this is on the trunk, incuding the google.ro replacing.

Comment 14

[Axel Hecht [:Pike]]

I don't see a fix in region.properties, re comment 1.

Comment 15

[Alexandru Szasz]

The change is in head ( http://lxr.mozilla.org/l10n/source/ro/browser/chrome/browser-region/region.properties )

It was commited the last time the tree was updated from 1.5.0 to 2.0

Comment 16

[Axel Hecht [:Pike]]

Right. Duh on me.

Looks like charm. Leaving open only to verify the results with our testing toolchain once this landed on the branch.